2014-10-27 14:42:21

by Jan Kardell

[permalink] [raw]
Subject: rtc: NXP pcf8563 vs Haoyu hym8563

Hi,

Erlier this year the hym8563 driver was added to the kernel. When I compared
the datasheets of the NXP pcf8563 (that I use) and the Haoyu hym8563 I
cannot
find any significantdifferences between the two chips. Now is using
different
drivers for the two similar (or identical?) chips:
a) A mistake
b) A feature
c) Me beeing stupid?

The difference between the drivers is handling of century and that the
hym8563
driver support the clock output that both chips have.

//Jan


2014-10-27 15:38:25

by Heiko Stuebner

[permalink] [raw]
Subject: Re: rtc: NXP pcf8563 vs Haoyu hym8563

Hi Jan,

Am Montag, 27. Oktober 2014, 15:42:11 schrieb Jan Kardell:
> Hi,
>
> Erlier this year the hym8563 driver was added to the kernel. When I compared
> the datasheets of the NXP pcf8563 (that I use) and the Haoyu hym8563 I
> cannot
> find any significantdifferences between the two chips. Now is using
> different
> drivers for the two similar (or identical?) chips:
> a) A mistake
> b) A feature
> c) Me beeing stupid?

option A - a mistake

At the time I didn't check existing drivers for one with a compatible
interface - wrongly thinking different vendors wouldn't use the same
interfaces.

I learned from this and am not making this mistake again [0] :-), but haven't
had the time so far to consolidate the two rtc drivers back into one.


> The difference between the drivers is handling of century and that the
> hym8563
> driver support the clock output that both chips have.

Feel free to consolidate them if you have time to spare - alternativly I
hopefully also will have time for this some time in the future.


Heiko


[0] https://lkml.org/lkml/2014/9/14/178