Second attempt. I took the advice from Masami Hiramatsu and modified
my tests. I also added some helper functions to ftracetests as well.
I split the one function graph test into two. One to just test the
filtering of the function graph and another to test with stack tracer.
Steven Rostedt (Red Hat) (4):
ftracetest: Add clear_trace() helper to reset the trace file
ftracetest: Add disable/enable_tracing() helper calls
ftracetest: Add helper reset_tracer() function
ftracetest: Add a couple of ftrace test cases
----
tools/testing/selftests/ftrace/ftracetest | 3 +
.../ftrace/test.d/ftrace/fgraph-filter-stack.tc | 94 ++++++++++++++++++++++
.../ftrace/test.d/ftrace/fgraph-filter.tc | 49 +++++++++++
.../ftrace/test.d/ftrace/func_profiler.tc | 76 +++++++++++++++++
tools/testing/selftests/ftrace/test.d/functions | 16 ++++
5 files changed, 238 insertions(+)
(2014/11/04 6:27), Steven Rostedt wrote:
> Second attempt. I took the advice from Masami Hiramatsu and modified
> my tests. I also added some helper functions to ftracetests as well.
>
> I split the one function graph test into two. One to just test the
> filtering of the function graph and another to test with stack tracer.
This series looks good to me :)
Acked-by: Masami Hiramatsu <[email protected]>
for this series.
Thank you!
>
> Steven Rostedt (Red Hat) (4):
> ftracetest: Add clear_trace() helper to reset the trace file
> ftracetest: Add disable/enable_tracing() helper calls
> ftracetest: Add helper reset_tracer() function
> ftracetest: Add a couple of ftrace test cases
>
> ----
> tools/testing/selftests/ftrace/ftracetest | 3 +
> .../ftrace/test.d/ftrace/fgraph-filter-stack.tc | 94 ++++++++++++++++++++++
> .../ftrace/test.d/ftrace/fgraph-filter.tc | 49 +++++++++++
> .../ftrace/test.d/ftrace/func_profiler.tc | 76 +++++++++++++++++
> tools/testing/selftests/ftrace/test.d/functions | 16 ++++
> 5 files changed, 238 insertions(+)
>
>
>
--
Masami HIRAMATSU
Software Platform Research Dept. Linux Technology Research Center
Hitachi, Ltd., Yokohama Research Laboratory
E-mail: [email protected]
(2014/11/04 6:27), Steven Rostedt wrote:
> Second attempt. I took the advice from Masami Hiramatsu and modified
> my tests. I also added some helper functions to ftracetests as well.
>
> I split the one function graph test into two. One to just test the
> filtering of the function graph and another to test with stack tracer.
>
> Steven Rostedt (Red Hat) (4):
> ftracetest: Add clear_trace() helper to reset the trace file
> ftracetest: Add disable/enable_tracing() helper calls
> ftracetest: Add helper reset_tracer() function
BTW, I think you can fold these patches into one. No need to separate
for each helper functions.
Thank you,
--
Masami HIRAMATSU
Software Platform Research Dept. Linux Technology Research Center
Hitachi, Ltd., Yokohama Research Laboratory
E-mail: [email protected]
On Tue, 04 Nov 2014 18:30:37 +0900
Masami Hiramatsu <[email protected]> wrote:
> (2014/11/04 6:27), Steven Rostedt wrote:
> > Second attempt. I took the advice from Masami Hiramatsu and modified
> > my tests. I also added some helper functions to ftracetests as well.
> >
> > I split the one function graph test into two. One to just test the
> > filtering of the function graph and another to test with stack tracer.
> >
> > Steven Rostedt (Red Hat) (4):
> > ftracetest: Add clear_trace() helper to reset the trace file
> > ftracetest: Add disable/enable_tracing() helper calls
> > ftracetest: Add helper reset_tracer() function
>
> BTW, I think you can fold these patches into one. No need to separate
> for each helper functions.
Yeah, I probably should. I did those each at different times, and just
put them in separately.
-- Steve