2014-11-19 15:56:10

by Andreas Färber

[permalink] [raw]
Subject: [PATCH 1/4] ARM: dts: Add usb3503 pinctrl to exynos5250-spring

Reported-by: Doug Anderson <[email protected]>
Signed-off-by: Andreas Färber <[email protected]>
---
arch/arm/boot/dts/exynos5250-spring.dts | 2 ++
1 file changed, 2 insertions(+)

diff --git a/arch/arm/boot/dts/exynos5250-spring.dts b/arch/arm/boot/dts/exynos5250-spring.dts
index f5566f84d885..310764b6e28d 100644
--- a/arch/arm/boot/dts/exynos5250-spring.dts
+++ b/arch/arm/boot/dts/exynos5250-spring.dts
@@ -52,6 +52,8 @@
usb-hub {
compatible = "smsc,usb3503a";
reset-gpios = <&gpe1 0 GPIO_ACTIVE_LOW>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&hsic_reset>;
};

fixed-rate-clocks {
--
2.1.2


2014-11-19 17:00:11

by Javier Martinez Canillas

[permalink] [raw]
Subject: Re: [PATCH 1/4] ARM: dts: Add usb3503 pinctrl to exynos5250-spring

Hello Andreas,

On 11/19/2014 04:56 PM, Andreas Färber wrote:
> Reported-by: Doug Anderson <[email protected]>
> Signed-off-by: Andreas Färber <[email protected]>

Even though the patch is simple and is true that the subject explains
the change, I think that is always good to have a commit message anyways.

Patch looks good to me though:

Reviewed-by: Javier Martinez Canillas <[email protected]>

Best regards,
Javier

2014-11-22 14:33:27

by Kukjin Kim

[permalink] [raw]
Subject: Re: [PATCH 1/4] ARM: dts: Add usb3503 pinctrl to exynos5250-spring

On 11/20/14 01:59, Javier Martinez Canillas wrote:
> Hello Andreas,
>
> On 11/19/2014 04:56 PM, Andreas Färber wrote:
>> Reported-by: Doug Anderson <[email protected]>
>> Signed-off-by: Andreas Färber <[email protected]>
>
> Even though the patch is simple and is true that the subject explains
> the change, I think that is always good to have a commit message anyways.
>
> Patch looks good to me though:
>
> Reviewed-by: Javier Martinez Canillas <[email protected]>
>
Applied this series, thanks.

- Kukjin