2014-11-24 10:54:04

by Paul Bolle

[permalink] [raw]
Subject: [PATCH] [media] omap24xx/tcm825x: remove pointless Makefile entry

The deprecated omap2 camera drivers were recently removed. Both the
Kconfig symbol VIDEO_TCM825X and the drivers/staging/media/omap24xx
directory are gone. So the Makefile entry that references both is now
pointless. Remove it too.

Signed-off-by: Paul Bolle <[email protected]>
---
Tested by grepping the tree.

Triggered by commit db85a0403be4 ("[media] omap24xx/tcm825x: remove
deprecated omap2 camera drivers."), which is included in next-20141124.
What happened is that it removed only one of the two Makefile entries
for omap24xx.

drivers/staging/media/Makefile | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/staging/media/Makefile b/drivers/staging/media/Makefile
index 97bfef97f838..30fb352fc4a9 100644
--- a/drivers/staging/media/Makefile
+++ b/drivers/staging/media/Makefile
@@ -4,7 +4,6 @@ obj-$(CONFIG_LIRC_STAGING) += lirc/
obj-$(CONFIG_VIDEO_DT3155) += dt3155v4l/
obj-$(CONFIG_VIDEO_DM365_VPFE) += davinci_vpfe/
obj-$(CONFIG_VIDEO_OMAP4) += omap4iss/
-obj-$(CONFIG_VIDEO_TCM825X) += omap24xx/
obj-$(CONFIG_DVB_MN88472) += mn88472/
obj-$(CONFIG_DVB_MN88473) += mn88473/

--
1.9.3


2014-11-24 11:09:04

by Hans Verkuil (hansverk)

[permalink] [raw]
Subject: Re: [PATCH] [media] omap24xx/tcm825x: remove pointless Makefile entry

I found the same thing and it is already part of my pull request
to Mauro.

I'm setting this patch as Obsoleted in patchwork.

It's unclear what happened. My original patch definitely removed both
Makefile lines.

Regards,

Hans

On 11/24/14 11:53, Paul Bolle wrote:
> The deprecated omap2 camera drivers were recently removed. Both the
> Kconfig symbol VIDEO_TCM825X and the drivers/staging/media/omap24xx
> directory are gone. So the Makefile entry that references both is now
> pointless. Remove it too.
>
> Signed-off-by: Paul Bolle <[email protected]>
> ---
> Tested by grepping the tree.
>
> Triggered by commit db85a0403be4 ("[media] omap24xx/tcm825x: remove
> deprecated omap2 camera drivers."), which is included in next-20141124.
> What happened is that it removed only one of the two Makefile entries
> for omap24xx.
>
> drivers/staging/media/Makefile | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/staging/media/Makefile b/drivers/staging/media/Makefile
> index 97bfef97f838..30fb352fc4a9 100644
> --- a/drivers/staging/media/Makefile
> +++ b/drivers/staging/media/Makefile
> @@ -4,7 +4,6 @@ obj-$(CONFIG_LIRC_STAGING) += lirc/
> obj-$(CONFIG_VIDEO_DT3155) += dt3155v4l/
> obj-$(CONFIG_VIDEO_DM365_VPFE) += davinci_vpfe/
> obj-$(CONFIG_VIDEO_OMAP4) += omap4iss/
> -obj-$(CONFIG_VIDEO_TCM825X) += omap24xx/
> obj-$(CONFIG_DVB_MN88472) += mn88472/
> obj-$(CONFIG_DVB_MN88473) += mn88473/
>
>

2014-11-24 11:15:13

by Paul Bolle

[permalink] [raw]
Subject: Re: [PATCH] [media] omap24xx/tcm825x: remove pointless Makefile entry

On Mon, 2014-11-24 at 12:08 +0100, Hans Verkuil wrote:
> I found the same thing and it is already part of my pull request
> to Mauro.

Either way, this trivial issue will be solved.

Thanks,


Paul Bolle