2014-11-24 15:04:03

by Jens Axboe

[permalink] [raw]
Subject: Re: [PATCH 0/6] blk: introduce generic io stat accounting help function

On 11/23/2014 08:05 PM, Gu Zheng wrote:
> Many block drivers accounting io stat based on bio (e.g. NVMe...),
> the blk_account_io_start/end() which is based on request
> does not make sense to them, so here we introduce the similar help
> function named generic_start/end_io_acct base on raw sectors, and it can
> simplify some driver's open io accounting code.
>
> Gu Zheng (6):
> blk: introduce generic io stat accounting help function
> NVMe: use generic io stat accounting functions to simplify
> nvme_start/end_io_acct
> md/bcache: use generic io stats accounting functions to simplify io
> stat accounting
> drbd: use generic io stats accounting functions to simplify io stat
> accounting
> md: use generic io stats accounting functions to simplify io stat
> accounting
> block/rsxx: use generic io stats accounting functions to simplify io
> stat accounting

Thanks, this looks good. I'll apply it, except 2/6, since nvme no longer
uses them.

--
Jens Axboe


2014-11-25 06:00:22

by Gu Zheng

[permalink] [raw]
Subject: Re: [PATCH 0/6] blk: introduce generic io stat accounting help function

On 11/24/2014 11:03 PM, Jens Axboe wrote:

> On 11/23/2014 08:05 PM, Gu Zheng wrote:
>> Many block drivers accounting io stat based on bio (e.g. NVMe...),
>> the blk_account_io_start/end() which is based on request
>> does not make sense to them, so here we introduce the similar help
>> function named generic_start/end_io_acct base on raw sectors, and it can
>> simplify some driver's open io accounting code.
>>
>> Gu Zheng (6):
>> blk: introduce generic io stat accounting help function
>> NVMe: use generic io stat accounting functions to simplify
>> nvme_start/end_io_acct
>> md/bcache: use generic io stats accounting functions to simplify io
>> stat accounting
>> drbd: use generic io stats accounting functions to simplify io stat
>> accounting
>> md: use generic io stats accounting functions to simplify io stat
>> accounting
>> block/rsxx: use generic io stats accounting functions to simplify io
>> stat accounting
>
> Thanks, this looks good. I'll apply it, except 2/6, since nvme no longer uses them.

OK.

Thanks,
Gu

>