Subject: [PATCH v2] ARM: EXYNOS: use u8 for val[] in struct exynos_pmu_conf

Values stored in val[] are never bigger than a byte.

text data bss dec hex filename
7716 3692 8 11416 2c98 arch/arm/mach-exynos/pmu.o.before
5436 1908 8 7352 1cb8 arch/arm/mach-exynos/pmu.o.after

Cc: Pankaj Dubey <[email protected]>
Cc: Amit Daniel Kachhap <[email protected]>
Signed-off-by: Bartlomiej Zolnierkiewicz <[email protected]>
Acked-by: Kyungmin Park <[email protected]>
---
v2:
- rebased on top of next-20141126 branch of linux-next kernel tree
(it also applies fine to for-next branch of linux-samsung.git)

arch/arm/mach-exynos/pmu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/mach-exynos/pmu.c b/arch/arm/mach-exynos/pmu.c
index ccb0120..c15761c 100644
--- a/arch/arm/mach-exynos/pmu.c
+++ b/arch/arm/mach-exynos/pmu.c
@@ -25,7 +25,7 @@

struct exynos_pmu_conf {
unsigned int offset;
- unsigned int val[NUM_SYS_POWERDOWN];
+ u8 val[NUM_SYS_POWERDOWN];
};

struct exynos_pmu_data {
--
1.8.2.3


2014-11-26 17:49:09

by Kukjin Kim

[permalink] [raw]
Subject: Re: [PATCH v2] ARM: EXYNOS: use u8 for val[] in struct exynos_pmu_conf

On 11/27/14 02:21, Bartlomiej Zolnierkiewicz wrote:
> Values stored in val[] are never bigger than a byte.
>
> text data bss dec hex filename
> 7716 3692 8 11416 2c98 arch/arm/mach-exynos/pmu.o.before
> 5436 1908 8 7352 1cb8 arch/arm/mach-exynos/pmu.o.after
>
> Cc: Pankaj Dubey <[email protected]>
> Cc: Amit Daniel Kachhap <[email protected]>
> Signed-off-by: Bartlomiej Zolnierkiewicz <[email protected]>
> Acked-by: Kyungmin Park <[email protected]>
> ---
> v2:
> - rebased on top of next-20141126 branch of linux-next kernel tree
> (it also applies fine to for-next branch of linux-samsung.git)
>
> arch/arm/mach-exynos/pmu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-exynos/pmu.c b/arch/arm/mach-exynos/pmu.c
> index ccb0120..c15761c 100644
> --- a/arch/arm/mach-exynos/pmu.c
> +++ b/arch/arm/mach-exynos/pmu.c
> @@ -25,7 +25,7 @@
>
> struct exynos_pmu_conf {
> unsigned int offset;
> - unsigned int val[NUM_SYS_POWERDOWN];
> + u8 val[NUM_SYS_POWERDOWN];
> };
>
> struct exynos_pmu_data {

Applied, thanks.

- Kukjin