2014-11-29 15:30:37

by SF Markus Elfring

[permalink] [raw]
Subject: [PATCH 1/1] net-ipvlan: Deletion of an unnecessary check before the function call "free_percpu"

From: Markus Elfring <[email protected]>
Date: Sat, 29 Nov 2014 16:23:20 +0100

The free_percpu() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <[email protected]>
---
drivers/net/ipvlan/ipvlan_main.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/net/ipvlan/ipvlan_main.c b/drivers/net/ipvlan/ipvlan_main.c
index 96b71b0..feb1853 100644
--- a/drivers/net/ipvlan/ipvlan_main.c
+++ b/drivers/net/ipvlan/ipvlan_main.c
@@ -125,8 +125,7 @@ static void ipvlan_uninit(struct net_device *dev)
struct ipvl_dev *ipvlan = netdev_priv(dev);
struct ipvl_port *port = ipvlan->port;

- if (ipvlan->pcpu_stats)
- free_percpu(ipvlan->pcpu_stats);
+ free_percpu(ipvlan->pcpu_stats);

port->count -= 1;
if (!port->count)
--
2.1.3


Subject: Re: [PATCH 1/1] net-ipvlan: Deletion of an unnecessary check before the function call "free_percpu"

On Sat, Nov 29, 2014 at 7:30 AM, SF Markus Elfring
<[email protected]> wrote:
> From: Markus Elfring <[email protected]>
> Date: Sat, 29 Nov 2014 16:23:20 +0100
>
> The free_percpu() function tests whether its argument is NULL and then
> returns immediately. Thus the test around the call is not needed.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <[email protected]>
Acked-by: Mahesh Bandewar <[email protected]>
> ---
> drivers/net/ipvlan/ipvlan_main.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/net/ipvlan/ipvlan_main.c b/drivers/net/ipvlan/ipvlan_main.c
> index 96b71b0..feb1853 100644
> --- a/drivers/net/ipvlan/ipvlan_main.c
> +++ b/drivers/net/ipvlan/ipvlan_main.c
> @@ -125,8 +125,7 @@ static void ipvlan_uninit(struct net_device *dev)
> struct ipvl_dev *ipvlan = netdev_priv(dev);
> struct ipvl_port *port = ipvlan->port;
>
> - if (ipvlan->pcpu_stats)
> - free_percpu(ipvlan->pcpu_stats);
> + free_percpu(ipvlan->pcpu_stats);
>
> port->count -= 1;
> if (!port->count)
> --
> 2.1.3
>
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html

2014-12-06 05:10:32

by David Miller

[permalink] [raw]
Subject: Re: [PATCH 1/1] net-ipvlan: Deletion of an unnecessary check before the function call "free_percpu"

From: SF Markus Elfring <[email protected]>
Date: Sat, 29 Nov 2014 16:30:27 +0100

> From: Markus Elfring <[email protected]>
> Date: Sat, 29 Nov 2014 16:23:20 +0100
>
> The free_percpu() function tests whether its argument is NULL and then
> returns immediately. Thus the test around the call is not needed.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <[email protected]>

Applied.