2014-12-01 15:53:54

by Anjana Sasindran

Subject: [PATCH] staging: rtl8723au: hal: Removed spaces before starting of a line

This patch fix the checkpatch.pl warning:

WARNING: please, no spaces at the start of a line

Signed-off-by: Anjana Sasindran <[email protected]>
---
drivers/staging/rtl8723au/hal/odm_RegConfig8723A.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/rtl8723au/hal/odm_RegConfig8723A.c b/drivers/staging/rtl8723au/hal/odm_RegConfig8723A.c
index 88e0126..959e89e 100644
--- a/drivers/staging/rtl8723au/hal/odm_RegConfig8723A.c
+++ b/drivers/staging/rtl8723au/hal/odm_RegConfig8723A.c
@@ -20,7 +20,7 @@ odm_ConfigRFReg_8723A(
struct dm_odm_t *pDM_Odm,
u32 Addr,
u32 Data,
- enum RF_RADIO_PATH RF_PATH,
+enum RF_RADIO_PATH RF_PATH,
u32 RegAddr
)
{
@@ -60,7 +60,7 @@ odm_ConfigBB_AGC_8723A(
u32 Addr,
u32 Bitmask,
u32 Data
- )
+)
{
ODM_SetBBReg(pDM_Odm, Addr, Bitmask, Data);
/* Add 1us delay between BB/RF register setting. */
@@ -77,7 +77,7 @@ odm_ConfigBB_PHY_8723A(
u32 Addr,
u32 Bitmask,
u32 Data
- )
+)
{
if (Addr == 0xfe)
msleep(50);
--
1.9.1

2014-12-01 16:57:09

by Larry Finger

Subject: Re: [PATCH] staging: rtl8723au: hal: Removed spaces before starting of a line

On 12/01/2014 09:53 AM, Anjana Sasindran wrote:
> This patch fix the checkpatch.pl warning:
>
> WARNING: please, no spaces at the start of a line
>
> Signed-off-by: Anjana Sasindran <[email protected]>
> ---
> drivers/staging/rtl8723au/hal/odm_RegConfig8723A.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/rtl8723au/hal/odm_RegConfig8723A.c b/drivers/staging/rtl8723au/hal/odm_RegConfig8723A.c
> index 88e0126..959e89e 100644
> --- a/drivers/staging/rtl8723au/hal/odm_RegConfig8723A.c
> +++ b/drivers/staging/rtl8723au/hal/odm_RegConfig8723A.c
> @@ -20,7 +20,7 @@ odm_ConfigRFReg_8723A(
> struct dm_odm_t *pDM_Odm,
> u32 Addr,
> u32 Data,
> - enum RF_RADIO_PATH RF_PATH,
> +enum RF_RADIO_PATH RF_PATH,

NACK. You are blindly "fixing" a checkpatch warning, but you are making the code
worse!! Obviously, this line should start with a tab to make the arguments of
this routine line up. Even if you were to do that, the style would be wrong.

If I were fixing this section, my patch would look like:

--- a/drivers/staging/rtl8723au/hal/odm_RegConfig8723A.c
+++ b/drivers/staging/rtl8723au/hal/odm_RegConfig8723A.c
@@ -15,14 +15,8 @@

#include "odm_precomp.h"

-void
-odm_ConfigRFReg_8723A(
- struct dm_odm_t *pDM_Odm,
- u32 Addr,
- u32 Data,
- enum RF_RADIO_PATH RF_PATH,
- u32 RegAddr
- )
+void odm_ConfigRFReg_8723A(struct dm_odm_t *pDM_Odm, u32 Addr, u32 Data,
+ enum RF_RADIO_PATH RF_PATH, u32 RegAddr)
{
if (Addr == 0xfe) {
msleep(50);

That change would make the procedure entry line easier to read. Of course, the
commit message would need to say something like "checkpatch warns of spaces at
the beginning of a line. To fix this, the procedure entry is reformatted."

Caution, my patch fragment is white-space damaged. You will need to do it yourself.

> u32 RegAddr
> )
> {
> @@ -60,7 +60,7 @@ odm_ConfigBB_AGC_8723A(
> u32 Addr,
> u32 Bitmask,
> u32 Data
> - )
> +)
> {
> ODM_SetBBReg(pDM_Odm, Addr, Bitmask, Data);
> /* Add 1us delay between BB/RF register setting. */
> @@ -77,7 +77,7 @@ odm_ConfigBB_PHY_8723A(
> u32 Addr,
> u32 Bitmask,
> u32 Data
> - )
> +)
> {
> if (Addr == 0xfe)
> msleep(50);
>

Same criticism here.

Larry

2014-12-01 17:03:48

by Joe Perches

Subject: Re: [PATCH] staging: rtl8723au: hal: Removed spaces before starting of a line

On Mon, 2014-12-01 at 21:23 +0530, Anjana Sasindran wrote:
> This patch fix the checkpatch.pl warning:
> WARNING: please, no spaces at the start of a line
[]
> diff --git a/drivers/staging/rtl8723au/hal/odm_RegConfig8723A.c b/drivers/staging/rtl8723au/hal/odm_RegConfig8723A.c
[]
> @@ -20,7 +20,7 @@ odm_ConfigRFReg_8723A(
> struct dm_odm_t *pDM_Odm,
> u32 Addr,
> u32 Data,
> - enum RF_RADIO_PATH RF_PATH,
> +enum RF_RADIO_PATH RF_PATH,
.
This should have a leading tab indentation