LinuxLists.cc - [PATCH] Staging: bcm: Fix tab between spaces in InterfaceMacros.h This is a patch to the InterfaceMacros.h file that fixes an added tab instead of a space. Found by the checkpatch.pl tool.

2014-12-02 17:35:50

Subject: [PATCH] Staging: bcm: Fix tab between spaces in InterfaceMacros.h This is a patch to the InterfaceMacros.h file that fixes an added tab instead of a space. Found by the checkpatch.pl tool.

---
drivers/staging/bcm/InterfaceMacros.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/bcm/InterfaceMacros.h b/drivers/staging/bcm/InterfaceMacros.h
index fedb794..67e7b62 100644
--- a/drivers/staging/bcm/InterfaceMacros.h
+++ b/drivers/staging/bcm/InterfaceMacros.h
@@ -4,7 +4,7 @@
#define BCM_USB_MAX_READ_LENGTH 2048

#define MAXIMUM_USB_TCB 128
-#define MAXIMUM_USB_RCB 128
+#define MAXIMUM_USB_RCB 128

#define MAX_BUFFERS_PER_QUEUE 256

--
2.1.0

2014-12-02 17:52:17

by Matthias Beyer

[permalink] [raw]

Subject: Re: [PATCH] Staging: bcm: Fix tab between spaces in InterfaceMacros.h This is a patch to the InterfaceMacros.h file that fixes an added tab instead of a space. Found by the checkpatch.pl tool.

Hi Pieter,

as far as I know, this driver was removed from the source tree. Please
update your local copy of the kernel.

--
Mit freundlichen Gr??en,
Kind regards,
Matthias Beyer

Proudly sent with mutt.
Happily signed with gnupg.

On 02-12-2014 18:25:49, Pieter Waegeman wrote:
> ---
> drivers/staging/bcm/InterfaceMacros.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/bcm/InterfaceMacros.h b/drivers/staging/bcm/InterfaceMacros.h
> index fedb794..67e7b62 100644
> --- a/drivers/staging/bcm/InterfaceMacros.h
> +++ b/drivers/staging/bcm/InterfaceMacros.h
> @@ -4,7 +4,7 @@
> #define BCM_USB_MAX_READ_LENGTH 2048
>
> #define MAXIMUM_USB_TCB 128
> -#define MAXIMUM_USB_RCB 128
> +#define MAXIMUM_USB_RCB 128
>
> #define MAX_BUFFERS_PER_QUEUE 256
>
> --
> 2.1.0
>

Attachments:

(No filename) (834.00 B)
(No filename) (819.00 B)
Download all attachments

2014-12-02 18:08:15

by Matthias Beyer

[permalink] [raw]

Subject: Re: [PATCH] Staging: bcm: Fix tab between spaces in InterfaceMacros.h This is a patch to the InterfaceMacros.h file that fixes an added tab instead of a space. Found by the checkpatch.pl tool.

Hi Pieter,

On 02-12-2014 19:04:31, 1Ago - Pieter Waegeman wrote:
> That's weird. I can still see the driver in the 'master' branch on
> https://github.com/torvalds/linux/tree/master/drivers/staging/bcm
> I've cloned from
> git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
>
> Or am I doing something wrong?

nope, you've done everything right. BUT the staging stuff gets
developed in the repo/branch from gregkh, so you should base your
patches to drivers/staging on that branch. And there, this driver is
removed already!

Feel free to contact me directly if you get stuck with it!

--
Mit freundlichen Gr??en,
Kind regards,
Matthias Beyer

Proudly sent with mutt.
Happily signed with gnupg.

Attachments:

(No filename) (712.00 B)
(No filename) (819.00 B)
Download all attachments

2014-12-02 18:10:51

by 1Ago - Pieter Waegeman

[permalink] [raw]

Subject: Re: [PATCH] Staging: bcm: Fix tab between spaces in InterfaceMacros.h This is a patch to the InterfaceMacros.h file that fixes an added tab instead of a space. Found by the checkpatch.pl tool.

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi Matthias,

Thanks for your feedback!

That's weird. I can still see the driver in the 'master' branch on
https://github.com/torvalds/linux/tree/master/drivers/staging/bcm
I've cloned from
git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git

Or am I doing something wrong?

- --
Greetings,

Pieter Waegeman

On 02-12-14 18:39, Matthias Beyer wrote:
> Hi Pieter,
>
> as far as I know, this driver was removed from the source tree. Please
> update your local copy of the kernel.
>

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQEcBAEBAgAGBQJUff8vAAoJENs4BoqSFFN4IN0H/RMITMT1o4+A2rsQ1p3r7aYp
3wamfJPuN0Famlfx03kKS7GKyb7GOdcsbXulDuLJ4Fx+tb1yxoBKwIeaGoNJ6niH
PQVUGNL547Qx5R5koBDPcz4N+Yy/fOKmlj4BhNCSfBZvfEsUOnH2cfrNy5OupPZf
P8DvjLV157uESjC2Hf4+h9EIkp5v363xIUi6TnbaZoDKq3cS16ji8qmKf4JIqE7M
dHX7og902zKGDisJvKk34k7ktJleNsVipfVqvF6MofsNwsqRcatTE4Bzmvai4pKU
gjbFW0v6lDSj/WYYme8idcvoyPc92lrFR9FTXBXsLaN88fjDI4LNnrUY8esi368=
=uJDo
-----END PGP SIGNATURE-----