2014-12-10 08:10:00

by Stephen Rothwell

[permalink] [raw]
Subject: linux-next: build failure after merge of the rcu tree

Hi Paul,

After merging the rcu tree, today's linux-next build (powerpc64
allnoconfig) failed like this:

In file included from arch/powerpc/include/asm/kvm_ppc.h:30:0,
from arch/powerpc/kernel/setup_64.c:68:
include/linux/kvm_host.h:366:21: error: field 'srcu' has incomplete type
struct srcu_struct srcu;
^
include/linux/kvm_host.h:367:21: error: field 'irq_srcu' has incomplete type
struct srcu_struct irq_srcu;
^

Presumably caused by commit 6e8ef258b669 ("srcu: Isolate srcu sections
using CONFIG_SRCU").

I have reverted that commit again for today - more work required ...

--
Cheers,
Stephen Rothwell [email protected]

Attachments:
(No filename) (819.00 B)
OpenPGP digital signature

2014-12-10 15:03:54

by Pranith Kumar

[permalink] [raw]
Subject: Re: linux-next: build failure after merge of the rcu tree

On 12/10/2014 03:09 AM, Stephen Rothwell wrote:
> Hi Paul,
>
> After merging the rcu tree, today's linux-next build (powerpc64
> allnoconfig) failed like this:
>
> In file included from arch/powerpc/include/asm/kvm_ppc.h:30:0,
> from arch/powerpc/kernel/setup_64.c:68:
> include/linux/kvm_host.h:366:21: error: field 'srcu' has incomplete type
> struct srcu_struct srcu;
> ^
> include/linux/kvm_host.h:367:21: error: field 'irq_srcu' has incomplete type
> struct srcu_struct irq_srcu;
> ^
>
> Presumably caused by commit 6e8ef258b669 ("srcu: Isolate srcu sections
> using CONFIG_SRCU").
>
> I have reverted that commit again for today - more work required ...
>

Looks like there are other places which use KVM unconditionally. I will try to look and fix such uses.

Paul, can you drop the patch until then? Thanks!
--
Pranith

2014-12-10 15:18:46

by Paul E. McKenney

[permalink] [raw]
Subject: Re: linux-next: build failure after merge of the rcu tree

On Wed, Dec 10, 2014 at 10:03:57AM -0500, Pranith Kumar wrote:
> On 12/10/2014 03:09 AM, Stephen Rothwell wrote:
> > Hi Paul,
> >
> > After merging the rcu tree, today's linux-next build (powerpc64
> > allnoconfig) failed like this:
> >
> > In file included from arch/powerpc/include/asm/kvm_ppc.h:30:0,
> > from arch/powerpc/kernel/setup_64.c:68:
> > include/linux/kvm_host.h:366:21: error: field 'srcu' has incomplete type
> > struct srcu_struct srcu;
> > ^
> > include/linux/kvm_host.h:367:21: error: field 'irq_srcu' has incomplete type
> > struct srcu_struct irq_srcu;
> > ^
> >
> > Presumably caused by commit 6e8ef258b669 ("srcu: Isolate srcu sections
> > using CONFIG_SRCU").
> >
> > I have reverted that commit again for today - more work required ...
> >
>
> Looks like there are other places which use KVM unconditionally. I will try to look and fix such uses.
>
> Paul, can you drop the patch until then? Thanks!

Done!

Thanx, Paul