2014-12-10 08:00:42

by Asaf Vertz

[permalink] [raw]
Subject: [PATCH] dma: imx-sdma: fix indentation

Fixed a coding style error, switch and case should be at the same indent

Signed-off-by: Asaf Vertz <[email protected]>
---
drivers/dma/imx-sdma.c | 18 +++++++++---------
1 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c
index 88afc48..8729877 100644
--- a/drivers/dma/imx-sdma.c
+++ b/drivers/dma/imx-sdma.c
@@ -1301,15 +1301,15 @@ static void sdma_load_firmware(const struct firmware *fw, void *context)
if (header->ram_code_start + header->ram_code_size > fw->size)
goto err_firmware;
switch (header->version_major) {
- case 1:
- sdma->script_number = SDMA_SCRIPT_ADDRS_ARRAY_SIZE_V1;
- break;
- case 2:
- sdma->script_number = SDMA_SCRIPT_ADDRS_ARRAY_SIZE_V2;
- break;
- default:
- dev_err(sdma->dev, "unknown firmware version\n");
- goto err_firmware;
+ case 1:
+ sdma->script_number = SDMA_SCRIPT_ADDRS_ARRAY_SIZE_V1;
+ break;
+ case 2:
+ sdma->script_number = SDMA_SCRIPT_ADDRS_ARRAY_SIZE_V2;
+ break;
+ default:
+ dev_err(sdma->dev, "unknown firmware version\n");
+ goto err_firmware;
}

addr = (void *)header + header->script_addrs_start;
--
1.7.0.4


2014-12-11 04:49:50

by Vinod Koul

[permalink] [raw]
Subject: Re: [PATCH] dma: imx-sdma: fix indentation

On Wed, Dec 10, 2014 at 10:00:36AM +0200, Asaf Vertz wrote:
> Fixed a coding style error, switch and case should be at the same indent
Please use the right subsystem name for the patches

Applied, now

Thanks
--
~Vinod

2014-12-11 07:23:34

by Asaf Vertz

[permalink] [raw]
Subject: Re: [PATCH] dma: imx-sdma: fix indentation

On 12/11/2014 06:50 AM, Vinod Koul wrote:
> On Wed, Dec 10, 2014 at 10:00:36AM +0200, Asaf Vertz wrote:
>> Fixed a coding style error, switch and case should be at the same indent
> Please use the right subsystem name for the patches

what subsystem name I should have used?
I used the one from the last patches in the log

http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/log/drivers/dma/imx-sdma.c

2014-12-15 08:15:48

by Vinod Koul

[permalink] [raw]
Subject: Re: [PATCH] dma: imx-sdma: fix indentation

On Thu, Dec 11, 2014 at 09:23:23AM +0200, Asaf Vertz wrote:
> On 12/11/2014 06:50 AM, Vinod Koul wrote:
> > On Wed, Dec 10, 2014 at 10:00:36AM +0200, Asaf Vertz wrote:
> >> Fixed a coding style error, switch and case should be at the same indent
> > Please use the right subsystem name for the patches
>
> what subsystem name I should have used?
> I used the one from the last patches in the log
>
> http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/log/drivers/dma/imx-sdma.c

$ git llog drivers/dma/pl330.c | grep "dma: pl" |wc -l
22
$ git log drivers/dma/pl330.c | grep "dmaengine: pl" |wc -l
32

and these are last commits

$ git log --oneline drivers/dma/pl330.c
046209f61b5f dmaengine: pl330: update author info
cee42392f5f0 dmaengine: pl330: Correct device assignment.
6e4a2a83f958 dmaengine: pl330: Fix NULL pointer dereference on driver unbind
0f5ebabdd03b dmaengine: pl330: Fix NULL pointer dereference on probe failure
c3cb38f43cb9 dmaengine: pl330: Remove unused 'regs' variable in pl330_submit_req()
937cb2f2498d dmaengine: pl330: Remove non-NULL check for pl330_submit_req parameters
31c1e5a1350a dmaengine: Remove the context argument to the prep_dma_cyclic operation
b1e51d771fbc dmaengine: pl330: Check if the DMA descriptor is NULL
c26939e5204c dmaengine: pl330: Remove pl330_chan_ctrl()
8ed30a14265f dmaengine: pl330: Simplify marking a request as unused
9dc5a315fe51 dmaengine: pl330: Embed pl330_req directly into dma_pl330_desc
f6f2421c0a1c dmaengine: pl330: Merge dma_pl330_dmac and pl330_dmac structs
fbbcd9be96a0 dmaengine: pl330: Simplify is_manager()

--
~Vinod