2014-12-21 12:55:33

by Rickard Strandqvist

Subject: [PATCH] arch: x86: kernel: apb_timer.c: Remove unused function

Remove the function is_apbt_capable() that is not used anywhere.

This was partially found by using a static code analysis program called cppcheck.

Signed-off-by: Rickard Strandqvist <[email protected]>
---
arch/x86/kernel/apb_timer.c | 8 --------
1 file changed, 8 deletions(-)

diff --git a/arch/x86/kernel/apb_timer.c b/arch/x86/kernel/apb_timer.c
index b708738..6a7c23f 100644
--- a/arch/x86/kernel/apb_timer.c
+++ b/arch/x86/kernel/apb_timer.c
@@ -135,14 +135,6 @@ static inline void apbt_clear_mapping(void)
apbt_virt_address = NULL;
}

-/*
- * APBT timer interrupt enable / disable
- */
-static inline int is_apbt_capable(void)
-{
- return apbt_virt_address ? 1 : 0;
-}
-
static int __init apbt_clockevent_register(void)
{
struct sfi_timer_table_entry *mtmr;
--
1.7.10.4

2014-12-22 03:18:57

by Jiang Liu

Subject: Re: [PATCH] arch: x86: kernel: apb_timer.c: Remove unused function

On 2014/12/21 20:58, Rickard Strandqvist wrote:
> Remove the function is_apbt_capable() that is not used anywhere.
>
> This was partially found by using a static code analysis program called cppcheck.
>
> Signed-off-by: Rickard Strandqvist <[email protected]>
> ---
> arch/x86/kernel/apb_timer.c | 8 --------
> 1 file changed, 8 deletions(-)
>
> diff --git a/arch/x86/kernel/apb_timer.c b/arch/x86/kernel/apb_timer.c
> index b708738..6a7c23f 100644
> --- a/arch/x86/kernel/apb_timer.c
> +++ b/arch/x86/kernel/apb_timer.c
> @@ -135,14 +135,6 @@ static inline void apbt_clear_mapping(void)
> apbt_virt_address = NULL;
> }
>
> -/*
> - * APBT timer interrupt enable / disable
> - */
> -static inline int is_apbt_capable(void)
> -{
> - return apbt_virt_address ? 1 : 0;
> -}
> -
> static int __init apbt_clockevent_register(void)
> {
> struct sfi_timer_table_entry *mtmr;
>
Reviewed-by: Jiang Liu <[email protected]>

2014-12-23 14:37:10

by tip-bot for Vasyl Gomonovych

Subject: [tip:x86/platform] x86/platform: Remove unused function from apb_timer.c

Commit-ID: 2b261f9f7bd9333e62140ca7e02a2f4ffec5e44f
Gitweb: http://git.kernel.org/tip/2b261f9f7bd9333e62140ca7e02a2f4ffec5e44f
Author: Rickard Strandqvist <[email protected]>
AuthorDate: Sun, 21 Dec 2014 13:58:18 +0100
Committer: Ingo Molnar <[email protected]>
CommitDate: Tue, 23 Dec 2014 10:43:35 +0100

x86/platform: Remove unused function from apb_timer.c

Remove the function is_apbt_capable() that is not used anywhere.

This was partially found by using a static code analysis program
called 'cppcheck'.

Signed-off-by: Rickard Strandqvist <[email protected]>
Reviewed-by: Jiang Liu <[email protected]>
Cc: Christoph Lameter <[email protected]>
Cc: Tejun Heo <[email protected]>
Link: http://lkml.kernel.org/r/1419166698-2470-1-git-send-email-rickard_strandqvist@spectrumdigital.se
Signed-off-by: Ingo Molnar <[email protected]>
---
arch/x86/kernel/apb_timer.c | 8 --------
1 file changed, 8 deletions(-)

diff --git a/arch/x86/kernel/apb_timer.c b/arch/x86/kernel/apb_timer.c
index b708738..6a7c23f 100644
--- a/arch/x86/kernel/apb_timer.c
+++ b/arch/x86/kernel/apb_timer.c
@@ -135,14 +135,6 @@ static inline void apbt_clear_mapping(void)
apbt_virt_address = NULL;
}

-/*
- * APBT timer interrupt enable / disable
- */
-static inline int is_apbt_capable(void)
-{
- return apbt_virt_address ? 1 : 0;
-}
-
static int __init apbt_clockevent_register(void)
{
struct sfi_timer_table_entry *mtmr;