2015-02-03 19:21:11

by Stefan Seyfried

[permalink] [raw]
Subject: Re: [PATCH 1/2] Revert "blk-mq: fix hctx/ctx kobject use-after-free"

Am 29.01.2015 um 13:17 schrieb Ming Lei:
> This reverts commit 76d697d10769048e5721510100bf3a9413a56385.
>
> The commit 76d697d10769048 causes general protection fault
> reported from Bart Van Assche:
>
> https://lkml.org/lkml/2015/1/28/334

I bisected the "unplugging my USB stick crashes the kernel" problem
today and came to this very commit.

The revert is not yet in Linus' tree (but it should get there before
3.19 is released, or all USB-stick users will be unhappy).

Best regards,

Stefan

> Reported-by: Bart Van Assche <[email protected]>
> Signed-off-by: Ming Lei <[email protected]>
--
Stefan Seyfried
Linux Consultant & Developer -- GPG Key: 0x731B665B

B1 Systems GmbH
Osterfeldstraße 7 / 85088 Vohburg / http://www.b1-systems.de
GF: Ralph Dehner / Unternehmenssitz: Vohburg / AG: Ingolstadt,HRB 3537


2015-02-03 19:14:52

by Jens Axboe

[permalink] [raw]
Subject: Re: [PATCH 1/2] Revert "blk-mq: fix hctx/ctx kobject use-after-free"

On 02/03/2015 12:13 PM, Stefan Seyfried wrote:
> Am 29.01.2015 um 13:17 schrieb Ming Lei:
>> This reverts commit 76d697d10769048e5721510100bf3a9413a56385.
>>
>> The commit 76d697d10769048 causes general protection fault
>> reported from Bart Van Assche:
>>
>> https://lkml.org/lkml/2015/1/28/334
>
> I bisected the "unplugging my USB stick crashes the kernel" problem
> today and came to this very commit.
>
> The revert is not yet in Linus' tree (but it should get there before
> 3.19 is released, or all USB-stick users will be unhappy).

It'll go out later today.

--
Jens Axboe

2015-02-03 21:50:58

by Jens Axboe

[permalink] [raw]
Subject: Re: [PATCH 1/2] Revert "blk-mq: fix hctx/ctx kobject use-after-free"

On 02/03/2015 12:14 PM, Jens Axboe wrote:
> On 02/03/2015 12:13 PM, Stefan Seyfried wrote:
>> Am 29.01.2015 um 13:17 schrieb Ming Lei:
>>> This reverts commit 76d697d10769048e5721510100bf3a9413a56385.
>>>
>>> The commit 76d697d10769048 causes general protection fault
>>> reported from Bart Van Assche:
>>>
>>> https://lkml.org/lkml/2015/1/28/334
>>
>> I bisected the "unplugging my USB stick crashes the kernel" problem
>> today and came to this very commit.
>>
>> The revert is not yet in Linus' tree (but it should get there before
>> 3.19 is released, or all USB-stick users will be unhappy).
>
> It'll go out later today.

It's in Linus' tree now.

--
Jens Axboe

2015-02-04 07:44:00

by Stefan Seyfried

[permalink] [raw]
Subject: Re: [PATCH 1/2] Revert "blk-mq: fix hctx/ctx kobject use-after-free"

Am 03.02.2015 um 22:50 schrieb Jens Axboe:
> On 02/03/2015 12:14 PM, Jens Axboe wrote:
>> On 02/03/2015 12:13 PM, Stefan Seyfried wrote:
>>> Am 29.01.2015 um 13:17 schrieb Ming Lei:
>>>> This reverts commit 76d697d10769048e5721510100bf3a9413a56385.
>>> The revert is not yet in Linus' tree (but it should get there before
>>> 3.19 is released, or all USB-stick users will be unhappy).
>>
>> It'll go out later today.
>
> It's in Linus' tree now.

...and works well for my trivial "plug and unplug an USB stick" testcase.
(I did not want to push, just make sure it wasn't forgotten :)

Thanks all,

Stefan
--
Stefan Seyfried
Linux Consultant & Developer -- GPG Key: 0x731B665B

B1 Systems GmbH
Osterfeldstraße 7 / 85088 Vohburg / http://www.b1-systems.de
GF: Ralph Dehner / Unternehmenssitz: Vohburg / AG: Ingolstadt,HRB 3537