2015-02-07 08:27:00

by Mark Brown

[permalink] [raw]
Subject: Re: [PATCH 2/3] ASoC: atmel_ssc_dai: refactor the startup and shutdown

On Fri, Jan 30, 2015 at 05:38:43PM +0800, Bo Shen wrote:
> In startup function, enable ssc clock and in shutdown function,
> disable clock. And also remove disable ssc in shutdown function,
> as ssc is disabled in prepare function.

Applied, thanks. You probably want to convert to clk_prepare_enable()
too but that's a separate thing.

Attachments:
(No filename) (337.00 B)
 signature.asc (473.00 B)
Digital signature Download all attachments

2015-02-09 00:53:09

by Bo Shen

[permalink] [raw]
Subject: Re: [PATCH 2/3] ASoC: atmel_ssc_dai: refactor the startup and shutdown

Hi Mark,

On 01/30/2015 09:20 PM, Mark Brown wrote:
> On Fri, Jan 30, 2015 at 05:38:43PM +0800, Bo Shen wrote:
>> In startup function, enable ssc clock and in shutdown function,
>> disable clock. And also remove disable ssc in shutdown function,
>> as ssc is disabled in prepare function.
>
> Applied, thanks. You probably want to convert to clk_prepare_enable()
> too but that's a separate thing.

OK, thanks, I will check that. As now, we prepare clock in ssc driver,
then enable it in dai driver.

Best Regards,
Bo Shen