2015-02-10 12:57:26

by Krzysztof Kozlowski

Subject: [PATCH] ARM: EXYNOS: Use platform device name as power domain name

The power domain nodes in DTS may be very generic (e.g. "power-domain"
for Exynos 5420) making it very hard to debug:

$ cat /sys/kernel/debug/pm_genpd/pm_genpd_summary
domain status slaves
power-domain on

Use platform device name instead so the names will be a little more user
friendly:
domain status slaves
100440e0.power-domain on

Signed-off-by: Krzysztof Kozlowski <[email protected]>
Suggested-by: Javier Martinez Canillas <[email protected]>
Suggested-by: Sergei Shtylyov <[email protected]>
---
arch/arm/mach-exynos/pm_domains.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/mach-exynos/pm_domains.c b/arch/arm/mach-exynos/pm_domains.c
index 20f267121b3e..37642ea97d23 100644
--- a/arch/arm/mach-exynos/pm_domains.c
+++ b/arch/arm/mach-exynos/pm_domains.c
@@ -125,7 +125,7 @@ static __init int exynos4_pm_init_power_domain(void)
return -ENOMEM;
}

- pd->pd.name = kstrdup(np->name, GFP_KERNEL);
+ pd->pd.name = kstrdup(dev_name(dev), GFP_KERNEL);
pd->name = pd->pd.name;
pd->base = of_iomap(np, 0);
pd->pd.power_off = exynos_pd_power_off;
--
1.9.1

2015-02-10 13:12:08

by Javier Martinez Canillas

Subject: Re: [PATCH] ARM: EXYNOS: Use platform device name as power domain name

Hello

Krzysztof,

On 02/10/2015 01:57 PM, Krzysztof Kozlowski wrote:
> The power domain nodes in DTS may be very generic (e.g. "power-domain"
> for Exynos 5420) making it very hard to debug:
>
> $ cat /sys/kernel/debug/pm_genpd/pm_genpd_summary
> domain status slaves
> power-domain on
>
> Use platform device name instead so the names will be a little more user
> friendly:
> domain status slaves
> 100440e0.power-domain on
>

I would had preferred to have even more info like 100440e0.mau-power-domain.
Maybe using the OF aliases approach that Sylwester suggested? But in any case
that could be complementary to your patch.

> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> Suggested-by: Javier Martinez Canillas <[email protected]>
> Suggested-by: Sergei Shtylyov <[email protected]>

Reviewed-by: Javier Martinez Canillas <[email protected]>

Best regards,
Javier