2015-02-11 11:10:57

by Luis de Bethencourt

Subject: [PATCH v2] rtl2832: remove compiler warning

Cleaning up the following compiler warning:
rtl2832.c:703:12: warning: 'tmp' may be used uninitialized in this function

Even though it could never happen since if rtl2832_rd_demod_reg () doesn't set
tmp, this line would never run because we go to err. It is still nice to avoid
compiler warnings.

Signed-off-by: Luis de Bethencourt <[email protected]>
---
drivers/media/dvb-frontends/rtl2832.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/dvb-frontends/rtl2832.c b/drivers/media/dvb-frontends/rtl2832.c
index 5d2d8f4..20fa245 100644
--- a/drivers/media/dvb-frontends/rtl2832.c
+++ b/drivers/media/dvb-frontends/rtl2832.c
@@ -685,7 +685,7 @@ static int rtl2832_read_status(struct dvb_frontend *fe, fe_status_t *status)
struct rtl2832_dev *dev = fe->demodulator_priv;
struct i2c_client *client = dev->client;
int ret;
- u32 tmp;
+ u32 uninitialized_var(tmp);

dev_dbg(&client->dev, "\n");

--
2.1.3

2015-02-11 13:07:13

by Antti Palosaari

Subject: Re: [PATCH v2] rtl2832: remove compiler warning

On 02/11/2015 01:08 PM, Luis de Bethencourt wrote:
> Cleaning up the following compiler warning:
> rtl2832.c:703:12: warning: 'tmp' may be used uninitialized in this function
>
> Even though it could never happen since if rtl2832_rd_demod_reg () doesn't set
> tmp, this line would never run because we go to err. It is still nice to avoid
> compiler warnings.
>
> Signed-off-by: Luis de Bethencourt <[email protected]>


Reviewed-by: Antti Palosaari <[email protected]>

Antti

> ---
> drivers/media/dvb-frontends/rtl2832.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/dvb-frontends/rtl2832.c b/drivers/media/dvb-frontends/rtl2832.c
> index 5d2d8f4..20fa245 100644
> --- a/drivers/media/dvb-frontends/rtl2832.c
> +++ b/drivers/media/dvb-frontends/rtl2832.c
> @@ -685,7 +685,7 @@ static int rtl2832_read_status(struct dvb_frontend *fe, fe_status_t *status)
> struct rtl2832_dev *dev = fe->demodulator_priv;
> struct i2c_client *client = dev->client;
> int ret;
> - u32 tmp;
> + u32 uninitialized_var(tmp);
>
> dev_dbg(&client->dev, "\n");
>
>

--
http://palosaari.fi/

2015-02-15 22:46:38

by Luis de Bethencourt

Subject: Re: [PATCH v2] rtl2832: remove compiler warning

On Wed, Feb 11, 2015 at 11:08:51AM +0000, Luis de Bethencourt wrote:
> Cleaning up the following compiler warning:
> rtl2832.c:703:12: warning: 'tmp' may be used uninitialized in this function
>
> Even though it could never happen since if rtl2832_rd_demod_reg () doesn't set
> tmp, this line would never run because we go to err. It is still nice to avoid
> compiler warnings.
>
> Signed-off-by: Luis de Bethencourt <[email protected]>
> ---
> drivers/media/dvb-frontends/rtl2832.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/dvb-frontends/rtl2832.c b/drivers/media/dvb-frontends/rtl2832.c
> index 5d2d8f4..20fa245 100644
> --- a/drivers/media/dvb-frontends/rtl2832.c
> +++ b/drivers/media/dvb-frontends/rtl2832.c
> @@ -685,7 +685,7 @@ static int rtl2832_read_status(struct dvb_frontend *fe, fe_status_t *status)
> struct rtl2832_dev *dev = fe->demodulator_priv;
> struct i2c_client *client = dev->client;
> int ret;
> - u32 tmp;
> + u32 uninitialized_var(tmp);
>
> dev_dbg(&client->dev, "\n");
>
> --
> 2.1.3
>

Hi Mauro,

The warning is still happening. Just a reminder in case you want to apply this
patch.

Thanks,
Luis