2015-02-02 21:13:31

by Michal Marek

[permalink] [raw]
Subject: Re: [PATCH v3 0/2] x86/arm64: add xenconfig

Dne 30.1.2015 v 19:25 Luis R. Rodriguez napsal(a):
> On Fri, Jan 30, 2015 at 2:49 AM, Michal Marek <[email protected]> wrote:
>> On 2015-01-29 21:47, Paul Bolle wrote:
>>> [Added Michal. Removed Yann.]
>>>
>>> On Thu, 2015-01-29 at 12:38 -0800, Luis R. Rodriguez wrote:
>>>> On Tue, Jan 27, 2015 at 12:00 PM, Luis R. Rodriguez <[email protected]> wrote:
>>>>> On Fri, Jan 23, 2015 at 03:19:25PM +0000, Stefano Stabellini wrote:
>>>>>> On Fri, 23 Jan 2015, Luis R. Rodriguez wrote:
>>>>>>> On Wed, Jan 14, 2015 at 11:33:45AM -0800, Luis R. Rodriguez wrote:
>>>>>>>> From: "Luis R. Rodriguez" <[email protected]>
>>>>>>>>
>>>>>>>> This v3 addresses Stefano's feedback from the v2 series, namely
>>>>>>>> moving PCI stuff to x86 as its all x86 specific and also just
>>>>>>>> removing the CONFIG_TCG_XEN=m from the general config. To be
>>>>>>>> clear the changes from the v2 series are below.
>>>>>>>>
>>>>>>>> Luis R. Rodriguez (2):
>>>>>>>> x86, platform, xen, kconfig: clarify kvmconfig is for kvm
>>>>>>>> x86, arm, platform, xen, kconfig: add xen defconfig helper
>>>>>>>>
>>>>>>>> arch/x86/configs/xen.config | 10 ++++++++++
>>>>>>>> kernel/configs/xen.config | 26 ++++++++++++++++++++++++++
>>>>>>>> scripts/kconfig/Makefile | 7 ++++++-
>>>>>>>> 3 files changed, 42 insertions(+), 1 deletion(-)
>>>>>>>> create mode 100644 arch/x86/configs/xen.config
>>>>>>>> create mode 100644 kernel/configs/xen.config
>>>>>>>
>>>>>>> Who could these changes go through?
>>>>>>
>>>>>> I would be OK with taking it in the Xen tree, but I would feel more
>>>>>> comfortable doing that if you had an ack from Yann Morin (CC'ed).
>>>>>
>>>>> *Poke*
>>>>
>>>> Hey Yann, wondering if you had any feedback. Thanks.
>>>
>>> Yann has disappeared a year ago. Michal now, informally, keeps an eye on
>>> kconfig related patches.
>>
>> I did not see this. Can you please bounce me the original series?
>
> Done, let me know if you did not get them

I got them, sorry for the delay. You can add Acked-by: Michal Marek
<[email protected]> if you want.

Michal


2015-02-02 21:32:28

by Luis Chamberlain

[permalink] [raw]
Subject: Re: [PATCH v3 0/2] x86/arm64: add xenconfig

On Mon, Feb 2, 2015 at 1:13 PM, Michal Marek <[email protected]> wrote:
> Dne 30.1.2015 v 19:25 Luis R. Rodriguez napsal(a):
>> On Fri, Jan 30, 2015 at 2:49 AM, Michal Marek <[email protected]> wrote:
>>> On 2015-01-29 21:47, Paul Bolle wrote:
>>>> [Added Michal. Removed Yann.]
>>>>
>>>> On Thu, 2015-01-29 at 12:38 -0800, Luis R. Rodriguez wrote:
>>>>> On Tue, Jan 27, 2015 at 12:00 PM, Luis R. Rodriguez <[email protected]> wrote:
>>>>>> On Fri, Jan 23, 2015 at 03:19:25PM +0000, Stefano Stabellini wrote:
>>>>>>> On Fri, 23 Jan 2015, Luis R. Rodriguez wrote:
>>>>>>>> On Wed, Jan 14, 2015 at 11:33:45AM -0800, Luis R. Rodriguez wrote:
>>>>>>>>> From: "Luis R. Rodriguez" <[email protected]>
>>>>>>>>>
>>>>>>>>> This v3 addresses Stefano's feedback from the v2 series, namely
>>>>>>>>> moving PCI stuff to x86 as its all x86 specific and also just
>>>>>>>>> removing the CONFIG_TCG_XEN=m from the general config. To be
>>>>>>>>> clear the changes from the v2 series are below.
>>>>>>>>>
>>>>>>>>> Luis R. Rodriguez (2):
>>>>>>>>> x86, platform, xen, kconfig: clarify kvmconfig is for kvm
>>>>>>>>> x86, arm, platform, xen, kconfig: add xen defconfig helper
>>>>>>>>>
>>>>>>>>> arch/x86/configs/xen.config | 10 ++++++++++
>>>>>>>>> kernel/configs/xen.config | 26 ++++++++++++++++++++++++++
>>>>>>>>> scripts/kconfig/Makefile | 7 ++++++-
>>>>>>>>> 3 files changed, 42 insertions(+), 1 deletion(-)
>>>>>>>>> create mode 100644 arch/x86/configs/xen.config
>>>>>>>>> create mode 100644 kernel/configs/xen.config
>>>>>>>>
>>>>>>>> Who could these changes go through?
>>>>>>>
>>>>>>> I would be OK with taking it in the Xen tree, but I would feel more
>>>>>>> comfortable doing that if you had an ack from Yann Morin (CC'ed).
>>>>>>
>>>>>> *Poke*
>>>>>
>>>>> Hey Yann, wondering if you had any feedback. Thanks.
>>>>
>>>> Yann has disappeared a year ago. Michal now, informally, keeps an eye on
>>>> kconfig related patches.
>>>
>>> I did not see this. Can you please bounce me the original series?
>>
>> Done, let me know if you did not get them
>
> I got them, sorry for the delay. You can add Acked-by: Michal Marek
> <[email protected]> if you want.

Thanks Michal, what tree should this go through though?

Luis

2015-02-07 00:08:37

by Luis Chamberlain

[permalink] [raw]
Subject: Re: [PATCH v3 0/2] x86/arm64: add xenconfig

On Mon, Feb 2, 2015 at 1:32 PM, Luis R. Rodriguez
<[email protected]> wrote:
> On Mon, Feb 2, 2015 at 1:13 PM, Michal Marek <[email protected]> wrote:
>> Dne 30.1.2015 v 19:25 Luis R. Rodriguez napsal(a):
>>> On Fri, Jan 30, 2015 at 2:49 AM, Michal Marek <[email protected]> wrote:
>>>> On 2015-01-29 21:47, Paul Bolle wrote:
>>>>> [Added Michal. Removed Yann.]
>>>>>
>>>>> On Thu, 2015-01-29 at 12:38 -0800, Luis R. Rodriguez wrote:
>>>>>> On Tue, Jan 27, 2015 at 12:00 PM, Luis R. Rodriguez <[email protected]> wrote:
>>>>>>> On Fri, Jan 23, 2015 at 03:19:25PM +0000, Stefano Stabellini wrote:
>>>>>>>> On Fri, 23 Jan 2015, Luis R. Rodriguez wrote:
>>>>>>>>> On Wed, Jan 14, 2015 at 11:33:45AM -0800, Luis R. Rodriguez wrote:
>>>>>>>>>> From: "Luis R. Rodriguez" <[email protected]>
>>>>>>>>>>
>>>>>>>>>> This v3 addresses Stefano's feedback from the v2 series, namely
>>>>>>>>>> moving PCI stuff to x86 as its all x86 specific and also just
>>>>>>>>>> removing the CONFIG_TCG_XEN=m from the general config. To be
>>>>>>>>>> clear the changes from the v2 series are below.
>>>>>>>>>>
>>>>>>>>>> Luis R. Rodriguez (2):
>>>>>>>>>> x86, platform, xen, kconfig: clarify kvmconfig is for kvm
>>>>>>>>>> x86, arm, platform, xen, kconfig: add xen defconfig helper
>>>>>>>>>>
>>>>>>>>>> arch/x86/configs/xen.config | 10 ++++++++++
>>>>>>>>>> kernel/configs/xen.config | 26 ++++++++++++++++++++++++++
>>>>>>>>>> scripts/kconfig/Makefile | 7 ++++++-
>>>>>>>>>> 3 files changed, 42 insertions(+), 1 deletion(-)
>>>>>>>>>> create mode 100644 arch/x86/configs/xen.config
>>>>>>>>>> create mode 100644 kernel/configs/xen.config
>>>>>>>>>
>>>>>>>>> Who could these changes go through?
>>>>>>>>
>>>>>>>> I would be OK with taking it in the Xen tree, but I would feel more
>>>>>>>> comfortable doing that if you had an ack from Yann Morin (CC'ed).
>>>>>>>
>>>>>>> *Poke*
>>>>>>
>>>>>> Hey Yann, wondering if you had any feedback. Thanks.
>>>>>
>>>>> Yann has disappeared a year ago. Michal now, informally, keeps an eye on
>>>>> kconfig related patches.
>>>>
>>>> I did not see this. Can you please bounce me the original series?
>>>
>>> Done, let me know if you did not get them
>>
>> I got them, sorry for the delay. You can add Acked-by: Michal Marek
>> <[email protected]> if you want.
>
> Thanks Michal, what tree should this go through though?

David should this go through your tree? Can anyone provide pointers?

Luis

2015-02-10 22:21:35

by David Rientjes

[permalink] [raw]
Subject: Re: [PATCH v3 0/2] x86/arm64: add xenconfig

On Fri, 6 Feb 2015, Luis R. Rodriguez wrote:

> David should this go through your tree? Can anyone provide pointers?
>

I think it should probably go through Michal's tree?

It would help to have an ack from at least one of the x86 maintainers, so
maybe add Ingo Molnar <[email protected]> and Thomas Gleixner
<[email protected]>.

We need an update to the MAINTAINERS file if "Yann E. MORIN"
<[email protected]> isn't the active Kconfig maintainer anymore.

If all else fails, I'd try to ask Andrew Morton
<[email protected]> to route it.

2015-02-10 22:32:56

by Paul Bolle

[permalink] [raw]
Subject: Re: [PATCH v3 0/2] x86/arm64: add xenconfig

On Tue, 2015-02-10 at 14:21 -0800, David Rientjes wrote:
> We need an update to the MAINTAINERS file if "Yann E. MORIN"
> <[email protected]> isn't the active Kconfig maintainer anymore.

Yes, we do. Michal, what update would you suggest?

Thanks,


Paul Bolle

2015-02-25 15:44:24

by Michal Marek

[permalink] [raw]
Subject: Re: [PATCH v3 0/2] x86/arm64: add xenconfig

On 2015-02-10 23:32, Paul Bolle wrote:
> On Tue, 2015-02-10 at 14:21 -0800, David Rientjes wrote:
>> We need an update to the MAINTAINERS file if "Yann E. MORIN"
>> <[email protected]> isn't the active Kconfig maintainer anymore.
>
> Yes, we do. Michal, what update would you suggest?

I'll revert the patch that added Yann. That is, change the contact back
to me and the status to "Odd fixes".

Michal

2015-02-25 20:49:59

by David Rientjes

[permalink] [raw]
Subject: Re: [PATCH v3 0/2] x86/arm64: add xenconfig

On Wed, 25 Feb 2015, Michal Marek wrote:

> > On Tue, 2015-02-10 at 14:21 -0800, David Rientjes wrote:
> >> We need an update to the MAINTAINERS file if "Yann E. MORIN"
> >> <[email protected]> isn't the active Kconfig maintainer anymore.
> >
> > Yes, we do. Michal, what update would you suggest?
>
> I'll revert the patch that added Yann. That is, change the contact back
> to me and the status to "Odd fixes".
>

Woohoo, so does this mean that Luis's series will finally be merged into a
tree somewhere? It's been a lengthy wait to try to get this merged.

2015-02-25 21:05:44

by Luis Chamberlain

[permalink] [raw]
Subject: Re: [Xen-devel] [PATCH v3 0/2] x86/arm64: add xenconfig

On Wed, Feb 25, 2015 at 12:49 PM, David Rientjes <[email protected]> wrote:
> Woohoo, so does this mean that Luis's series will finally be merged into a
> tree somewhere? It's been a lengthy wait to try to get this merged.

David Rientjes (as I'm also Cc'ing David Vrabel),

I am reworking Xen's kconfig stuff right now, so perhaps what is best
is for this series to be folded under those changes and I'd submit
them as the last series in the changes. That would avoid collateral
changes as I revamp tons of Xen kconfig things. This would then go
under David Vrabel's tree, but since it involves x86 stuff its unclear
if its OK for that -- I think so? Let me know.

Luis

2015-02-25 21:11:09

by David Rientjes

[permalink] [raw]
Subject: Re: [Xen-devel] [PATCH v3 0/2] x86/arm64: add xenconfig

On Wed, 25 Feb 2015, Luis R. Rodriguez wrote:

> I am reworking Xen's kconfig stuff right now, so perhaps what is best
> is for this series to be folded under those changes and I'd submit
> them as the last series in the changes. That would avoid collateral
> changes as I revamp tons of Xen kconfig things. This would then go
> under David Vrabel's tree, but since it involves x86 stuff its unclear
> if its OK for that -- I think so? Let me know.
>

Ok, sounds good, and I agree it would be better to hold off on doing this
if there are going to be substantial changes to the config options later.
I think once the x86 bits get an ack from one of the x86 guys that you
should be good to go!

2015-02-25 21:20:06

by Konrad Rzeszutek Wilk

[permalink] [raw]
Subject: Re: [Xen-devel] [PATCH v3 0/2] x86/arm64: add xenconfig

On Wed, Feb 25, 2015 at 01:11:04PM -0800, David Rientjes wrote:
> On Wed, 25 Feb 2015, Luis R. Rodriguez wrote:
>
> > I am reworking Xen's kconfig stuff right now, so perhaps what is best
> > is for this series to be folded under those changes and I'd submit
> > them as the last series in the changes. That would avoid collateral
> > changes as I revamp tons of Xen kconfig things. This would then go
> > under David Vrabel's tree, but since it involves x86 stuff its unclear
> > if its OK for that -- I think so? Let me know.
> >
>
> Ok, sounds good, and I agree it would be better to hold off on doing this
> if there are going to be substantial changes to the config options later.
> I think once the x86 bits get an ack from one of the x86 guys that you
> should be good to go!

Ingo (x86 guys) mentioned in one of his emails that he glosses over
emails if they say 'xen'.

Perhaps you need to change the title to be more catchy?


>
> _______________________________________________
> Xen-devel mailing list
> [email protected]
> http://lists.xen.org/xen-devel

2015-02-25 21:26:23

by Luis Chamberlain

[permalink] [raw]
Subject: Re: [Xen-devel] [PATCH v3 0/2] x86/arm64: add xenconfig

On Wed, Feb 25, 2015 at 1:19 PM, Konrad Rzeszutek Wilk
<[email protected]> wrote:
> On Wed, Feb 25, 2015 at 01:11:04PM -0800, David Rientjes wrote:
>> On Wed, 25 Feb 2015, Luis R. Rodriguez wrote:
>>
>> > I am reworking Xen's kconfig stuff right now, so perhaps what is best
>> > is for this series to be folded under those changes and I'd submit
>> > them as the last series in the changes. That would avoid collateral
>> > changes as I revamp tons of Xen kconfig things. This would then go
>> > under David Vrabel's tree, but since it involves x86 stuff its unclear
>> > if its OK for that -- I think so? Let me know.
>> >
>>
>> Ok, sounds good, and I agree it would be better to hold off on doing this
>> if there are going to be substantial changes to the config options later.
>> I think once the x86 bits get an ack from one of the x86 guys that you
>> should be good to go!
>
> Ingo (x86 guys) mentioned in one of his emails that he glosses over
> emails if they say 'xen'.

Then this should be able to go through David Vrabel no, as he does care.

> Perhaps you need to change the title to be more catchy?

If folks don't want to deal with Xen patches it should be fine, but we
do need a route upstream, this seems to make sense to go through David
Vrabel in the future no?

Luis

2015-02-25 21:44:59

by Konrad Rzeszutek Wilk

[permalink] [raw]
Subject: Re: [Xen-devel] [PATCH v3 0/2] x86/arm64: add xenconfig

On Wed, Feb 25, 2015 at 01:25:59PM -0800, Luis R. Rodriguez wrote:
> On Wed, Feb 25, 2015 at 1:19 PM, Konrad Rzeszutek Wilk
> <[email protected]> wrote:
> > On Wed, Feb 25, 2015 at 01:11:04PM -0800, David Rientjes wrote:
> >> On Wed, 25 Feb 2015, Luis R. Rodriguez wrote:
> >>
> >> > I am reworking Xen's kconfig stuff right now, so perhaps what is best
> >> > is for this series to be folded under those changes and I'd submit
> >> > them as the last series in the changes. That would avoid collateral
> >> > changes as I revamp tons of Xen kconfig things. This would then go
> >> > under David Vrabel's tree, but since it involves x86 stuff its unclear
> >> > if its OK for that -- I think so? Let me know.
> >> >
> >>
> >> Ok, sounds good, and I agree it would be better to hold off on doing this
> >> if there are going to be substantial changes to the config options later.
> >> I think once the x86 bits get an ack from one of the x86 guys that you
> >> should be good to go!
> >
> > Ingo (x86 guys) mentioned in one of his emails that he glosses over
> > emails if they say 'xen'.
>
> Then this should be able to go through David Vrabel no, as he does care.

:-)
>
> > Perhaps you need to change the title to be more catchy?
>
> If folks don't want to deal with Xen patches it should be fine, but we
> do need a route upstream, this seems to make sense to go through David
> Vrabel in the future no?

Yes, any of the Xen maintainers (me, David, or Boris).

>
> Luis