by Janosch Frank

[permalink] [raw]

Subject: Re: [PATCH v3 01/14] KVM: s390: pv: add macros for UVC CC values

On 8/6/21 9:26 AM, David Hildenbrand wrote:
> On 04.08.21 17:40, Claudio Imbrenda wrote:
>> Add macros to describe the 4 possible CC values returned by the UVC
>> instruction.
>>
>> Signed-off-by: Claudio Imbrenda <[email protected]>
>> ---
>> arch/s390/include/asm/uv.h | 5 +++++
>> 1 file changed, 5 insertions(+)
>>
>> diff --git a/arch/s390/include/asm/uv.h b/arch/s390/include/asm/uv.h
>> index 12c5f006c136..b35add51b967 100644
>> --- a/arch/s390/include/asm/uv.h
>> +++ b/arch/s390/include/asm/uv.h
>> @@ -18,6 +18,11 @@
>> #include <asm/page.h>
>> #include <asm/gmap.h>
>>
>> +#define UVC_CC_OK 0
>> +#define UVC_CC_ERROR 1
>> +#define UVC_CC_BUSY 2
>> +#define UVC_CC_PARTIAL 3
>> +
>> #define UVC_RC_EXECUTED 0x0001
>> #define UVC_RC_INV_CMD 0x0002
>> #define UVC_RC_INV_STATE 0x0003
>>
>
> Do we have any users we could directly fix up? AFAIKs, most users don't
> really care about the cc value, only about cc vs !cc.
>
> The only instances I was able to spot quickly:

The only fix for the functions below that I would accept would be to
check for cc 2 and 3. A cc >= UVC_CC_BUSY confuses me way too much when
reading.

But honestly for those two I'd just keep the code as is. I only asked
Claudio to fix the code in the next patch and add this patch as it was
not clearly visible he was dealing with a CC.

>
>
> diff --git a/arch/s390/include/asm/uv.h b/arch/s390/include/asm/uv.h
> index 12c5f006c136..dd72d325f9e8 100644
> --- a/arch/s390/include/asm/uv.h
> +++ b/arch/s390/include/asm/uv.h
> @@ -233,7 +233,7 @@ static inline int uv_call(unsigned long r1, unsigned
> long r2)
>
> do {
> cc = __uv_call(r1, r2);
> - } while (cc > 1);
> + } while (cc >= UVC_CC_BUSY);
> return cc;
> }
>
> @@ -245,7 +245,7 @@ static inline int uv_call_sched(unsigned long r1,
> unsigned long r2)
> do {
> cc = __uv_call(r1, r2);
> cond_resched();
> - } while (cc > 1);
> + } while (cc >= UVC_CC_BUSY);
> return cc;
> }
>
>
> Of course, we could replace all checks for cc vs !cc with "cc !=
> UVC_CC_OK" vs "cc == UVC_CC_OK".
>

2021-08-09 08:53:57

by David Hildenbrand

[permalink] [raw]

Subject: Re: [PATCH v3 00/14] KVM: s390: pv: implement lazy destroy

On 06.08.21 15:44, Claudio Imbrenda wrote:
> On Fri, 6 Aug 2021 13:30:21 +0200
> David Hildenbrand <[email protected]> wrote:
>
> [...]
>
>>>>> When the system runs out of memory, if a guest has terminated and
>>>>> its memory is being cleaned asynchronously, the OOM killer will
>>>>> wait a little and then see if memory has been freed. This has the
>>>>> practical effect of slowing down memory allocations when the
>>>>> system is out of memory to give the cleanup thread time to
>>>>> cleanup and free memory, and avoid an actual OOM situation.
>>>>
>>>> ... and this sound like the kind of arch MM hacks that will bite us
>>>> in the long run. Of course, I might be wrong, but already doing
>>>> excessive GFP_ATOMIC allocations or messing with the OOM killer
>>>> that
>>>
>>> they are GFP_ATOMIC but they should not put too much weight on the
>>> memory and can also fail without consequences, I used:
>>>
>>> GFP_ATOMIC | __GFP_NOMEMALLOC | __GFP_NOWARN
>>>
>>> also notice that after every page allocation a page gets freed, so
>>> this is only temporary.
>>
>> Correct me if I'm wrong: you're allocating unmovable pages for
>> tracking (e.g., ZONE_DMA, ZONE_NORMAL) from atomic reserves and will
>> free a movable process page, correct? Or which page will you be
>> freeing?
>
> we are transforming ALL moveable pages belonging to userspace into
> unmoveable pages. every ~500 pages one page gets actually
> allocated (unmoveable), and another (moveable) one gets freed.
>
>>>
>>> I would not call it "messing with the OOM killer", I'm using the
>>> same interface used by virtio-baloon
>>
>> Right, and for virtio-balloon it's actually a workaround to restore
>> the original behavior of a rarely used feature: deflate-on-oom.
>> Commit da10329cb057 ("virtio-balloon: switch back to OOM handler for
>> VIRTIO_BALLOON_F_DEFLATE_ON_OOM") tried to document why we switched
>> back from a shrinker to VIRTIO_BALLOON_F_DEFLATE_ON_OOM:
>>
>> "The name "deflate on OOM" makes it pretty clear when deflation should
>> happen - after other approaches to reclaim memory failed, not while
>> reclaiming. This allows to minimize the footprint of a guest -
>> memory will only be taken out of the balloon when really needed."
>>
>> Note some subtle differences:
>>
>> a) IIRC, before running into the OOM killer, will try reclaiming
>> anything else. This is what we want for deflate-on-oom, it might
>> not be what you want for your feature (e.g., flushing other
>> processes/VMs to disk/swap instead of waiting for a single process to
>> stop).
>
> we are already reclaiming the memory of the dead secure guest.
>
>> b) Migration of movable balloon inflated pages continues working
>> because we are dealing with non-lru page migration.
>>
>> Will page reclaim, page migration, compaction, ... of these movable
>> LRU pages still continue working while they are sitting around
>> waiting to be cleaned up? I can see that we're grabbing an extra
>> reference when we put them onto the list, that might be a problem:
>> for example, we can most certainly not swap out these pages or write
>> them back to disk on memory pressure.
>
> this is true. on the other hand, swapping a moveable page would be even
> slower, because those pages would need to be exported and not destroyed.
>
>>>
>>>> way for a pure (shutdown) optimization is an alarm signal. Of
>>>> course, I might be wrong.
>>>>
>>>> You should at least CC linux-mm. I'll do that right now and also CC
>>>> Michal. He might have time to have a quick glimpse at patch #11 and
>>>> #13.
>>>>
>>>> https://lkml.kernel.org/r/[email protected]
>>>> https://lkml.kernel.org/r/[email protected]
>>>>
>>>> IMHO, we should proceed with patch 1-10, as they solve a really
>>>> important problem ("slow reboots") in a nice way, whereby patch 11
>>>> handles a case that can be worked around comparatively easily by
>>>> management tools -- my 2 cents.
>>>
>>> how would management tools work around the issue that a shutdown can
>>> take very long?
>>
>> The traditional approach is to wait starting a new VM on another
>> hypervisor instead until memory has been freed up, or start it on
>> another hypervisor. That raises the question about the target use
>> case.
>>
>> What I don't get is that we have to pay the price for freeing up that
>> memory. Why isn't it sufficient to keep the process running and let
>> ordinary MM do it's thing?
>
> what price?
>
> you mean let mm do the slowest possible thing when tearing down a dead
> guest?
>
> without this, the dying guest would still take up all the memory. and
> swapping it would not be any faster (it would be slower, in fact). the
> system would OOM anyway.
>
>> Maybe you should clearly spell out what the target use case for the
>> fast shutdown (fast quitting of the process?) is?. I assume it is,
>> starting a new VM / process / whatsoever on the same host
>> immediately, and then
>>
>> a) Eventually slowing down other processes due heavy reclaim.
>
> for each dying guest, only one CPU is used by the reclaim; depending on
> the total load of the system, this might not even be noticeable
>
>> b) Slowing down the new process because you have to pay the price of
>> cleaning up memory.
>
> do you prefer to OOM because the dying guest will need ages to clean up
> its memory?
>
>> I think I am missing why we need the lazy destroy at all when killing
>> a process. Couldn't you instead teach the OOM killer "hey, we're
>> currently quitting a heavy process that is just *very* slow to free
>> up memory, please wait for that before starting shooting around" ?
>
> isn't this ^ exactly what the OOM notifier does?
>
>
> another note here:
>
> when the process quits, the mm starts the tear down. at this point, the
> mm has no idea that this is a dying KVM guest, so the best it can do is
> exporting (which is significantly slower than destroy page)
>
> kvm comes into play long after the mm is gone, and at this point it
> can't do anything anymore. the memory is already gone (very slowly).
>
> if I kill -9 qemu (or if qemu segfaults), KVM will never notice until
> the mm is gone.
>

Summarizing what we discussed offline:

1. We should optimize for proper shutdowns first, this is the most
important use case. We should look into letting QEMU tear down the KVM
secure context such that we can just let MM teardown do its thing ->
destroy instead of export secure pages. If no kernel changes are
required to get that implemented, even better.

2. If we want to optimize "there is a big process dying horribly slow,
please OOM killer please wait a bit instead of starting killing other
processes", we might want to do that in a more generic way (if not
already in place, no expert).

3. If we really want to go down the path of optimizing "kill -9" and
friends to e.g., take 40min instead of 20min on a huge VM (who cares?
especially, the OOM handler will struggle already if memory is getting
freed that slowly, no matter if 40 or 20 minutes), we should look into
being able to release the relevant KVM secure context before tearing
down MM. We should avoid any arch specific hacks.

--
Thanks,

David / dhildenb