2015-04-02 03:43:47

by John Stultz

Subject: [PATCH v2] kselftests: timers: Make set-timer-lat fail more gracefully for !CAP_WAKE_ALARM

The set-timer-lat test fails when testing CLOCK_BOOTTIME_ALARM
or CLOCK_REALTIME_ALARM when the user isn't running as root or
with CAP_WAKE_ALARM.

So this patch improves the error checking so we report the
issue more clearly and continue rather then reporting a failure.

Cc: Shuah Khan <[email protected]>
Cc: Prarit Bhargava <[email protected]>
Cc: Thomas Gleixner <[email protected]>
Cc: Richard Cochran <[email protected]>
Signed-off-by: John Stultz <[email protected]>
---
v2: Fix a few checkpatch warnings.

tools/testing/selftests/timers/set-timer-lat.c | 7 +++++++
1 file changed, 7 insertions(+)

diff --git a/tools/testing/selftests/timers/set-timer-lat.c b/tools/testing/selftests/timers/set-timer-lat.c
index 2ed3267..4fc98c5 100644
--- a/tools/testing/selftests/timers/set-timer-lat.c
+++ b/tools/testing/selftests/timers/set-timer-lat.c
@@ -139,6 +139,13 @@ int do_timer(int clock_id, int flags)

err = timer_create(clock_id, &se, &tm1);
if (err) {
+ if ((clock_id == CLOCK_REALTIME_ALARM) ||
+ (clock_id == CLOCK_BOOTTIME_ALARM)) {
+ printf("%-22s %s missing CAP_WAKE_ALARM? : [UNSUPPORTED]\n",
+ clockstring(clock_id),
+ flags ? "ABSTIME":"RELTIME");
+ return 0;
+ }
printf("%s - timer_create() failed\n", clockstring(clock_id));
return -1;
}
--
1.9.1

2015-04-02 14:21:17

by Shuah Khan

Subject: Re: [PATCH v2] kselftests: timers: Make set-timer-lat fail more gracefully for !CAP_WAKE_ALARM

On 04/01/2015 09:43 PM, John Stultz wrote:
> The set-timer-lat test fails when testing CLOCK_BOOTTIME_ALARM
> or CLOCK_REALTIME_ALARM when the user isn't running as root or
> with CAP_WAKE_ALARM.
>
> So this patch improves the error checking so we report the
> issue more clearly and continue rather then reporting a failure.
>
> Cc: Shuah Khan <[email protected]>
> Cc: Prarit Bhargava <[email protected]>
> Cc: Thomas Gleixner <[email protected]>
> Cc: Richard Cochran <[email protected]>
> Signed-off-by: John Stultz <[email protected]>
> ---
> v2: Fix a few checkpatch warnings.
>

Thanks. I will get this into 4.1-rc2.

-- Shuah


--
Shuah Khan
Sr. Linux Kernel Developer
Open Source Innovation Group
Samsung Research America (Silicon Valley)
[email protected] | (970) 217-8978

2015-04-02 18:50:25

by Shuah Khan

Subject: Re: [PATCH v2] kselftests: timers: Make set-timer-lat fail more gracefully for !CAP_WAKE_ALARM

On 04/02/2015 08:21 AM, Shuah Khan wrote:
> On 04/01/2015 09:43 PM, John Stultz wrote:
>> The set-timer-lat test fails when testing CLOCK_BOOTTIME_ALARM
>> or CLOCK_REALTIME_ALARM when the user isn't running as root or
>> with CAP_WAKE_ALARM.
>>
>> So this patch improves the error checking so we report the
>> issue more clearly and continue rather then reporting a failure.
>>
>> Cc: Shuah Khan <[email protected]>
>> Cc: Prarit Bhargava <[email protected]>
>> Cc: Thomas Gleixner <[email protected]>
>> Cc: Richard Cochran <[email protected]>
>> Signed-off-by: John Stultz <[email protected]>
>> ---
>> v2: Fix a few checkpatch warnings.
>>
>
> Thanks. I will get this into 4.1-rc2.
>

Applied to linux-kselftest next for 4.1

thanks,
-- Shuah


--
Shuah Khan
Sr. Linux Kernel Developer
Open Source Innovation Group
Samsung Research America (Silicon Valley)
[email protected] | (970) 217-8978