2015-04-07 03:21:06

by Yunlong Song

Subject: Re: [PATCH 0/9] perf sched replay: Make some improvements and fixes

On 2015/3/31 21:46, Yunlong Song wrote:
> Hi,
> Found some functions to improve and bugs to fix in perf sched replay.
>
> Yunlong Song (9):
> perf sched replay: Use struct task_desc instead of struct task_task
> for correct meaning
> perf sched replay: Increase the MAX_PID value to fix assertion failure
> problem
> perf sched replay: Alloc the memory of pid_to_task dynamically to
> adapt to the unexpected change of pid_max
> perf sched replay: Realloc the memory of pid_to_task stepwise to adapt
> to the different pid_max configurations
> perf sched replay: Fix the segmentation fault problem caused by pr_err
> in threads
> perf sched replay: Handle the dead halt of sem_wait when
> create_tasks() fails for any task
> perf sched replay: Fix the EMFILE error caused by the limitation of
> the maximum open files
> perf sched replay: Support using -f to override perf.data file
> ownership
> perf sched replay: Use replay_repeat to calculate the runavg of cpu
> usage instead of the default value 10
>
> tools/perf/builtin-sched.c | 67 +++++++++++++++++++++++++++++++++++-----------
> 1 file changed, 52 insertions(+), 15 deletions(-)
>

Ping...

--
Thanks,
Yunlong Song

2015-04-07 13:53:41

by Arnaldo Carvalho de Melo

Subject: Re: [PATCH 0/9] perf sched replay: Make some improvements and fixes

Em Tue, Apr 07, 2015 at 11:20:42AM +0800, Yunlong Song escreveu:
> On 2015/3/31 21:46, Yunlong Song wrote:
> > Hi,
> > Found some functions to improve and bugs to fix in perf sched replay.
> >
> > Yunlong Song (9):
> > perf sched replay: Use struct task_desc instead of struct task_task
> > for correct meaning
> > perf sched replay: Increase the MAX_PID value to fix assertion failure
> > problem
> > perf sched replay: Alloc the memory of pid_to_task dynamically to
> > adapt to the unexpected change of pid_max
> > perf sched replay: Realloc the memory of pid_to_task stepwise to adapt
> > to the different pid_max configurations
> > perf sched replay: Fix the segmentation fault problem caused by pr_err
> > in threads
> > perf sched replay: Handle the dead halt of sem_wait when
> > create_tasks() fails for any task
> > perf sched replay: Fix the EMFILE error caused by the limitation of
> > the maximum open files
> > perf sched replay: Support using -f to override perf.data file
> > ownership
> > perf sched replay: Use replay_repeat to calculate the runavg of cpu
> > usage instead of the default value 10
> >
> > tools/perf/builtin-sched.c | 67 +++++++++++++++++++++++++++++++++++-----------
> > 1 file changed, 52 insertions(+), 15 deletions(-)
> >
>
> Ping...

All looks reasonable, applied.

David, please holler if you still have any concerns, or either we can
work from here, i.e. improving things with follow on patches.

- Arnaldo