2015-04-09 01:09:06

by Zefan Li

[permalink] [raw]
Subject: Re: [3.4 PATCH] Bluetooth: Fix invalid length check in l2cap_information_rsp()

On 2015/3/30 17:27, Tim Niemeyer wrote:
> first backport commit 6ec88fcb4aa2c33fe2fe2a23c576a7e2581c5c3d changes
> l2cap_move_channel_confirm_rsp and not the l2cap_information_rsp. So
> revert this and fix at the correct position.
>
> commit 3f6fa3d489e127ca5a5b298eabac3ff5dbe0e112 upstream.
>
> The length check is invalid since the length varies with type of
> info response.
>
> This was introduced by the commit cb3b3152b2f5939d67005cff841a1ca748b19888
>
> Because of this, l2cap info rsp is not handled and command reject is sent.
>
>> ACL data: handle 11 flags 0x02 dlen 16
> L2CAP(s): Info rsp: type 2 result 0
> Extended feature mask 0x00b8
> Enhanced Retransmission mode
> Streaming mode
> FCS Option
> Fixed Channels
> < ACL data: handle 11 flags 0x00 dlen 10
> L2CAP(s): Command rej: reason 0
> Command not understood
>
> Cc: [email protected]
> Signed-off-by: Jaganath Kanakkassery <[email protected]>
> Signed-off-by: Chan-Yeol Park <[email protected]>
> Signed-off-by: Gustavo Padovan <[email protected]>
> Cc: Jianguo Wu <[email protected]>
> Signed-off-by: Greg Kroah-Hartman <[email protected]>
> Signed-off-by: Tim Niemeyer <[email protected]>
> Acked-by: Johan Hedberg <[email protected]>
> ---
> Patch for 3.4-stable.
>

Queued up for 3.4. Thanks!