2015-04-12 15:10:11

by Valentin Rothberg

Subject: [PATCH] drivers/tty/serial/mcf.c: fix typo on MCF_CONSOLE

Correct reference in C-comment after #endif.

Signed-off-by: Valentin Rothberg <[email protected]>
---
I found this issue with ./scripts/checkkconfigsymbols.py
---
drivers/tty/serial/mcf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/tty/serial/mcf.c b/drivers/tty/serial/mcf.c
index a9b0ab38a68c..a61031eca1b7 100644
--- a/drivers/tty/serial/mcf.c
+++ b/drivers/tty/serial/mcf.c
@@ -597,7 +597,7 @@ console_initcall(mcf_console_init);
#define MCF_CONSOLE NULL

/****************************************************************************/
-#endif /* CONFIG_MCF_CONSOLE */
+#endif /* MCF_CONSOLE */
/****************************************************************************/

/*
--
2.1.0

2015-04-12 15:52:05

by Peter Hurley

Subject: Re: [PATCH] drivers/tty/serial/mcf.c: fix typo on MCF_CONSOLE

Hi Valentin,

On 04/12/2015 11:10 AM, Valentin Rothberg wrote:
> Correct reference in C-comment after #endif.
>
> Signed-off-by: Valentin Rothberg <[email protected]>
> ---
> I found this issue with ./scripts/checkkconfigsymbols.py
> ---
> drivers/tty/serial/mcf.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/tty/serial/mcf.c b/drivers/tty/serial/mcf.c
> index a9b0ab38a68c..a61031eca1b7 100644
> --- a/drivers/tty/serial/mcf.c
> +++ b/drivers/tty/serial/mcf.c
> @@ -597,7 +597,7 @@ console_initcall(mcf_console_init);
> #define MCF_CONSOLE NULL
>
> /****************************************************************************/
> -#endif /* CONFIG_MCF_CONSOLE */
> +#endif /* MCF_CONSOLE */

Please check your results; the correct change would be

#endif /* CONFIG_SERIAL_MCF_CONSOLE */

Regards,
Peter Hurley

> /****************************************************************************/
>
> /*
>

2015-04-12 16:00:59

by Valentin Rothberg

Subject: Re: [PATCH] drivers/tty/serial/mcf.c: fix typo on MCF_CONSOLE

Hi Peter,

On Sun, Apr 12, 2015 at 11:51:55AM -0400, Peter Hurley wrote:
> Hi Valentin,
>
> On 04/12/2015 11:10 AM, Valentin Rothberg wrote:
> > Correct reference in C-comment after #endif.
> >
> > Signed-off-by: Valentin Rothberg <[email protected]>
> > ---
> > I found this issue with ./scripts/checkkconfigsymbols.py
> > ---
> > drivers/tty/serial/mcf.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/tty/serial/mcf.c b/drivers/tty/serial/mcf.c
> > index a9b0ab38a68c..a61031eca1b7 100644
> > --- a/drivers/tty/serial/mcf.c
> > +++ b/drivers/tty/serial/mcf.c
> > @@ -597,7 +597,7 @@ console_initcall(mcf_console_init);
> > #define MCF_CONSOLE NULL
> >
> > /****************************************************************************/
> > -#endif /* CONFIG_MCF_CONSOLE */
> > +#endif /* MCF_CONSOLE */
>
> Please check your results; the correct change would be
>
> #endif /* CONFIG_SERIAL_MCF_CONSOLE */

Thank you for catching that. That's what I intended to; sorry for
this mistake. I'll send a second corrected version of this patch.

Kind regards,
Valentin

> Regards,
> Peter Hurley
>
> > /****************************************************************************/
> >
> > /*
> >
>