2015-04-15 15:54:18

by Randy Dunlap

[permalink] [raw]
Subject: [PATCH -next] input/touchscreen: fix sur40.c build errors

From: Randy Dunlap <[email protected]>

Fix build errors due to missing Kconfig dependency.

drivers/built-in.o: In function `sur40_disconnect':
sur40.c:(.text+0x22be6e): undefined reference to `video_unregister_device'
sur40.c:(.text+0x22be77): undefined reference to `v4l2_device_unregister'
drivers/built-in.o: In function `sur40_process_video':
sur40.c:(.text+0x22c1d4): undefined reference to `v4l2_get_timestamp'
drivers/built-in.o: In function `sur40_probe':
sur40.c:(.text+0x22ca82): undefined reference to `v4l2_device_register'
sur40.c:(.text+0x22cb1a): undefined reference to `v4l2_device_unregister'
sur40.c:(.text+0x22cbf7): undefined reference to `video_device_release_empty'
sur40.c:(.text+0x22cc53): undefined reference to `__video_register_device'
sur40.c:(.text+0x22cc90): undefined reference to `video_unregister_device'
drivers/built-in.o: In function `sur40_vidioc_querycap':
sur40.c:(.text+0x22ccb0): undefined reference to `video_devdata'

Signed-off-by: Randy Dunlap <[email protected]>
Cc: Florian 'floe' Echtler <[email protected]>
Cc: Dmitry Torokhov <[email protected]>
Cc: [email protected]
---
drivers/input/touchscreen/Kconfig | 1 +
1 file changed, 1 insertion(+)

--- linux-next-20150415.orig/drivers/input/touchscreen/Kconfig
+++ linux-next-20150415/drivers/input/touchscreen/Kconfig
@@ -981,6 +981,7 @@ config TOUCHSCREEN_SUR40
tristate "Samsung SUR40 (Surface 2.0/PixelSense) touchscreen"
depends on USB
depends on MEDIA_USB_SUPPORT
+ depends on VIDEO_V4L2
select INPUT_POLLDEV
select VIDEOBUF2_DMA_SG
help


2015-04-15 16:20:33

by Florian Echtler

[permalink] [raw]
Subject: Re: [PATCH -next] input/touchscreen: fix sur40.c build errors

Hello Randy,

On 15.04.2015 17:54, Randy Dunlap wrote:
> ---
> drivers/input/touchscreen/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> --- linux-next-20150415.orig/drivers/input/touchscreen/Kconfig
> +++ linux-next-20150415/drivers/input/touchscreen/Kconfig
> @@ -981,6 +981,7 @@ config TOUCHSCREEN_SUR40
> tristate "Samsung SUR40 (Surface 2.0/PixelSense) touchscreen"
> depends on USB
> depends on MEDIA_USB_SUPPORT
> + depends on VIDEO_V4L2
> select INPUT_POLLDEV
> select VIDEOBUF2_DMA_SG
> help
>
Thanks for catching this. I assumed videobuf2 would to auto-select
video-v4l2 in any case.

Best, Florian
--
SENT FROM MY DEC VT50 TERMINAL


Attachments:
signature.asc (181.00 B)
OpenPGP digital signature