2022-02-16 06:49:22

by kernel test robot

[permalink] [raw]
Subject: [deller-fbdev:for-next 51/51] drivers/video/fbdev/omap2/omapfb/dss/dss.c:1209:42: error: use of undeclared identifier 'component_compare_dev'; did you mean 'component_master_del'?

tree: git://git.kernel.org/pub/scm/linux/kernel/git/deller/linux-fbdev.git for-next
head: 61038027aa13351c63b452a0d48c805bab1d2ce9
commit: 61038027aa13351c63b452a0d48c805bab1d2ce9 [51/51] video: fbdev: omapfb: Make use of the helper component_compare_dev
config: arm-randconfig-c002-20220216 (https://download.01.org/0day-ci/archive/20220216/[email protected]/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project 0e628a783b935c70c80815db6c061ec84f884af5)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install arm cross compiling tool for clang build
# apt-get install binutils-arm-linux-gnueabi
# https://git.kernel.org/pub/scm/linux/kernel/git/deller/linux-fbdev.git/commit/?id=61038027aa13351c63b452a0d48c805bab1d2ce9
git remote add deller-fbdev git://git.kernel.org/pub/scm/linux/kernel/git/deller/linux-fbdev.git
git fetch --no-tags deller-fbdev for-next
git checkout 61038027aa13351c63b452a0d48c805bab1d2ce9
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm SHELL=/bin/bash drivers/video/fbdev/omap2/omapfb/dss/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <[email protected]>

All errors (new ones prefixed by >>):

>> drivers/video/fbdev/omap2/omapfb/dss/dss.c:1209:42: error: use of undeclared identifier 'component_compare_dev'; did you mean 'component_master_del'?
component_match_add(dev->parent, match, component_compare_dev, dev);
^~~~~~~~~~~~~~~~~~~~~
component_master_del
include/linux/component.h:85:6: note: 'component_master_del' declared here
void component_master_del(struct device *,
^
1 error generated.


vim +1209 drivers/video/fbdev/omap2/omapfb/dss/dss.c

1195
1196 static int dss_add_child_component(struct device *dev, void *data)
1197 {
1198 struct component_match **match = data;
1199
1200 /*
1201 * HACK
1202 * We don't have a working driver for rfbi, so skip it here always.
1203 * Otherwise dss will never get probed successfully, as it will wait
1204 * for rfbi to get probed.
1205 */
1206 if (strstr(dev_name(dev), "rfbi"))
1207 return 0;
1208
> 1209 component_match_add(dev->parent, match, component_compare_dev, dev);
1210
1211 return 0;
1212 }
1213

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/[email protected]


2022-02-16 07:44:47

by Yong Wu (吴勇)

[permalink] [raw]
Subject: Re: [deller-fbdev:for-next 51/51] drivers/video/fbdev/omap2/omapfb/dss/dss.c:1209:42: error: use of undeclared identifier 'component_compare_dev'; did you mean 'component_master_del'?

Hi Helge,

Thanks for apply this patch.

Sorry that I didn't Cc you in cover-letter. It depend on [1/23].

To avoid this build fail, Could you help revert this one?

Thanks

On Wed, 2022-02-16 at 13:31 +0800, kernel test robot wrote:
> tree: git://git.kernel.org/pub/scm/linux/kernel/git/deller/linux-
> fbdev.git for-next
> head: 61038027aa13351c63b452a0d48c805bab1d2ce9
> commit: 61038027aa13351c63b452a0d48c805bab1d2ce9 [51/51] video:
> fbdev: omapfb: Make use of the helper component_compare_dev
> config: arm-randconfig-c002-20220216 (
> https://download.01.org/0day-ci/archive/20220216/[email protected]/config
> )
> compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project
> 0e628a783b935c70c80815db6c061ec84f884af5)
> reproduce (this is a W=1 build):
> wget
> https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross
> -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> # install arm cross compiling tool for clang build
> # apt-get install binutils-arm-linux-gnueabi
> #
> https://git.kernel.org/pub/scm/linux/kernel/git/deller/linux-fbdev.git/commit/?id=61038027aa13351c63b452a0d48c805bab1d2ce9
> git remote add deller-fbdev
> git://git.kernel.org/pub/scm/linux/kernel/git/deller/linux-fbdev.git
> git fetch --no-tags deller-fbdev for-next
> git checkout 61038027aa13351c63b452a0d48c805bab1d2ce9
> # save the config file to linux build tree
> mkdir build_dir
> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross
> W=1 O=build_dir ARCH=arm SHELL=/bin/bash
> drivers/video/fbdev/omap2/omapfb/dss/
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <[email protected]>
>
> All errors (new ones prefixed by >>):
>
> > > drivers/video/fbdev/omap2/omapfb/dss/dss.c:1209:42: error: use of
> > > undeclared identifier 'component_compare_dev'; did you mean
> > > 'component_master_del'?
>
> component_match_add(dev->parent, match,
> component_compare_dev, dev);
> ^~~~~~~~~~~~~~~~~~
> ~~~
> component_master_d
> el
> include/linux/component.h:85:6: note: 'component_master_del'
> declared here
> void component_master_del(struct device *,
> ^
> 1 error generated.
>
>
> vim +1209 drivers/video/fbdev/omap2/omapfb/dss/dss.c
>
> 1195
> 1196 static int dss_add_child_component(struct device *dev,
> void *data)
> 1197 {
> 1198 struct component_match **match = data;
> 1199
> 1200 /*
> 1201 * HACK
> 1202 * We don't have a working driver for rfbi, so
> skip it here always.
> 1203 * Otherwise dss will never get probed
> successfully, as it will wait
> 1204 * for rfbi to get probed.
> 1205 */
> 1206 if (strstr(dev_name(dev), "rfbi"))
> 1207 return 0;
> 1208
> > 1209 component_match_add(dev->parent, match,
> > component_compare_dev, dev);
>
> 1210
> 1211 return 0;
> 1212 }
> 1213
>
> ---
> 0-DAY CI Kernel Test Service, Intel Corporation
> https://lists.01.org/hyperkitty/list/[email protected]