2015-05-07 10:05:26

by Masahiro Yamada

Subject: [PATCH] serial: 8250: do not copy port.fifosize member twice

The port.fifosize member has already been copied at 8 lines above.
Maybe the compiler optimization can clean it away, but just in case.

Signed-off-by: Masahiro Yamada <[email protected]>
---

drivers/tty/serial/8250/8250_core.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/tty/serial/8250/8250_core.c b/drivers/tty/serial/8250/8250_core.c
index 4506e40..4882027 100644
--- a/drivers/tty/serial/8250/8250_core.c
+++ b/drivers/tty/serial/8250/8250_core.c
@@ -3850,7 +3850,6 @@ int serial8250_register_8250_port(struct uart_8250_port *up)
uart->port.mapbase = up->port.mapbase;
uart->port.mapsize = up->port.mapsize;
uart->port.private_data = up->port.private_data;
- uart->port.fifosize = up->port.fifosize;
uart->tx_loadsz = up->tx_loadsz;
uart->capabilities = up->capabilities;
uart->port.throttle = up->port.throttle;
--
1.9.1

2015-05-07 10:12:16

by Peter Hurley

Subject: Re: [PATCH] serial: 8250: do not copy port.fifosize member twice

On 05/07/2015 06:04 AM, Masahiro Yamada wrote:
> The port.fifosize member has already been copied at 8 lines above.
> Maybe the compiler optimization can clean it away, but just in case.

Reviewed-by: Peter Hurley <[email protected]>