2015-05-08 05:53:20

by Joshua Kinard

[permalink] [raw]
Subject: Re: [PATCH] mips:Fix build error for ip32_defconfig configuration

On 05/07/2015 20:52, Nicholas Krause wrote:
> This fixes the make error when building the ip32_defconfig
> configuration due to using sgio2_cmos_devinit rather then
> the correct function,sgio2_rtc_devinit in a device_initcall
> below this function's definition.
>
> Signed-off-by: Nicholas Krause <[email protected]>
> ---
> arch/mips/sgi-ip32/ip32-platform.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/mips/sgi-ip32/ip32-platform.c b/arch/mips/sgi-ip32/ip32-platform.c
> index 0134db2..2a7efcb 100644
> --- a/arch/mips/sgi-ip32/ip32-platform.c
> +++ b/arch/mips/sgi-ip32/ip32-platform.c
> @@ -130,9 +130,9 @@ struct platform_device ip32_rtc_device = {
> .resource = ip32_rtc_resources,
> };
>
> -+static int __init sgio2_rtc_devinit(void)
> +static __init int sgio2_rtc_devinit(void)
> {
> return platform_device_register(&ip32_rtc_device);
> }
>
> -device_initcall(sgio2_cmos_devinit);
> +device_initcall(sgio2_rtc_devinit);
>

I believe I sent this patch in already, back on 04/19/2015. Didn't get an
acknowledgement on it from akpm, though.

--J