2015-04-17 06:24:49

by Seung-Woo Kim

Subject: [RESEND PATCH] Smack: ignore private inode for smack_file_receive

The dmabuf fd can be shared between processes via unix domain
socket. The file of dmabuf fd is came from anon_inode. The inode
has no set and get xattr operations, so it can not be shared
between processes with smack. This patch fixes just to ignore
private inode including anon_inode for smack_file_receive.

Signed-off-by: Seung-Woo Kim <[email protected]>
---
I think there was some issue sending my previous mail, so I resend patch again.
---
security/smack/smack_lsm.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/security/smack/smack_lsm.c b/security/smack/smack_lsm.c
index 69fdc38..d1bb411 100644
--- a/security/smack/smack_lsm.c
+++ b/security/smack/smack_lsm.c
@@ -1673,6 +1673,9 @@ static int smack_file_receive(struct file *file)
struct smk_audit_info ad;
struct inode *inode = file_inode(file);

+ if (unlikely(IS_PRIVATE(inode)))
+ return 0;
+
smk_ad_init(&ad, __func__, LSM_AUDIT_DATA_PATH);
smk_ad_setfield_u_fs_path(&ad, file->f_path);
/*
--
1.7.4.1

2015-05-11 08:12:55

by Seung-Woo Kim

Subject: Re: [RESEND PATCH] Smack: ignore private inode for smack_file_receive

Ping?

On 2015?? 04?? 17?? 15:25, Seung-Woo Kim wrote:
> The dmabuf fd can be shared between processes via unix domain
> socket. The file of dmabuf fd is came from anon_inode. The inode
> has no set and get xattr operations, so it can not be shared
> between processes with smack. This patch fixes just to ignore
> private inode including anon_inode for smack_file_receive.
>
> Signed-off-by: Seung-Woo Kim <[email protected]>
> ---
> I think there was some issue sending my previous mail, so I resend patch again.
> ---
> security/smack/smack_lsm.c | 3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/security/smack/smack_lsm.c b/security/smack/smack_lsm.c
> index 69fdc38..d1bb411 100644
> --- a/security/smack/smack_lsm.c
> +++ b/security/smack/smack_lsm.c
> @@ -1673,6 +1673,9 @@ static int smack_file_receive(struct file *file)
> struct smk_audit_info ad;
> struct inode *inode = file_inode(file);
>
> + if (unlikely(IS_PRIVATE(inode)))
> + return 0;
> +
> smk_ad_init(&ad, __func__, LSM_AUDIT_DATA_PATH);
> smk_ad_setfield_u_fs_path(&ad, file->f_path);
> /*
>

--
Seung-Woo Kim
Samsung Software R&D Center
--

2015-05-11 14:05:58

by Casey Schaufler

Subject: Re: [RESEND PATCH] Smack: ignore private inode for smack_file_receive

On 5/11/2015 1:12 AM, Seung-Woo Kim wrote:
> Ping?

It's in my queue for 4.2.

>
> On 2015?? 04?? 17?? 15:25, Seung-Woo Kim wrote:
>> The dmabuf fd can be shared between processes via unix domain
>> socket. The file of dmabuf fd is came from anon_inode. The inode
>> has no set and get xattr operations, so it can not be shared
>> between processes with smack. This patch fixes just to ignore
>> private inode including anon_inode for smack_file_receive.
>>
>> Signed-off-by: Seung-Woo Kim <[email protected]>
>> ---
>> I think there was some issue sending my previous mail, so I resend patch again.
>> ---
>> security/smack/smack_lsm.c | 3 +++
>> 1 files changed, 3 insertions(+), 0 deletions(-)
>>
>> diff --git a/security/smack/smack_lsm.c b/security/smack/smack_lsm.c
>> index 69fdc38..d1bb411 100644
>> --- a/security/smack/smack_lsm.c
>> +++ b/security/smack/smack_lsm.c
>> @@ -1673,6 +1673,9 @@ static int smack_file_receive(struct file *file)
>> struct smk_audit_info ad;
>> struct inode *inode = file_inode(file);
>>
>> + if (unlikely(IS_PRIVATE(inode)))
>> + return 0;
>> +
>> smk_ad_init(&ad, __func__, LSM_AUDIT_DATA_PATH);
>> smk_ad_setfield_u_fs_path(&ad, file->f_path);
>> /*
>>