2024-02-04 23:16:57

by Johan Jonker

[permalink] [raw]
Subject: [PATCH v1] arm64: dts: rockchip: rk3328: Drop interrupts property from pwm-rockchip nodes

The binding doesn't define interrupts and adding such a definition was
refused because it's unclear how they should ever be used and the
relevant registers are outside the PWM range. So drop them fixing
several dtbs_check warnings.

Signed-off-by: Johan Jonker <[email protected]>
---
arch/arm64/boot/dts/rockchip/rk3328.dtsi | 1 -
1 file changed, 1 deletion(-)

diff --git a/arch/arm64/boot/dts/rockchip/rk3328.dtsi b/arch/arm64/boot/dts/rockchip/rk3328.dtsi
index a73234b11ff1..b6f045069ee2 100644
--- a/arch/arm64/boot/dts/rockchip/rk3328.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3328.dtsi
@@ -488,7 +488,6 @@ pwm2: pwm@ff1b0020 {
pwm3: pwm@ff1b0030 {
compatible = "rockchip,rk3328-pwm";
reg = <0x0 0xff1b0030 0x0 0x10>;
- interrupts = <GIC_SPI 50 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&cru SCLK_PWM>, <&cru PCLK_PWM>;
clock-names = "pwm", "pclk";
pinctrl-names = "default";
--
2.39.2



2024-02-13 19:17:07

by Heiko Stübner

[permalink] [raw]
Subject: Re: [PATCH v1] arm64: dts: rockchip: rk3328: Drop interrupts property from pwm-rockchip nodes

On Mon, 5 Feb 2024 00:16:43 +0100, Johan Jonker wrote:
> The binding doesn't define interrupts and adding such a definition was
> refused because it's unclear how they should ever be used and the
> relevant registers are outside the PWM range. So drop them fixing
> several dtbs_check warnings.
>
>

Applied, thanks!

[1/1] arm64: dts: rockchip: rk3328: Drop interrupts property from pwm-rockchip nodes
commit: 1bbd894e2ae67faf52632bc9290ff926d9b741ea

Best regards,
--
Heiko Stuebner <[email protected]>