If the pwm-samsung driver is built as a module, modalias information is
not filled so the module is not autoloaded. Use the MODULE_DEVICE_TABLE()
macro to export the OF device ID so the module contains that information.
Signed-off-by: Javier Martinez Canillas <[email protected]>
---
drivers/pwm/pwm-samsung.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/pwm/pwm-samsung.c b/drivers/pwm/pwm-samsung.c
index ff201e1b9219..ada2d326dc3e 100644
--- a/drivers/pwm/pwm-samsung.c
+++ b/drivers/pwm/pwm-samsung.c
@@ -456,6 +456,7 @@ static const struct of_device_id samsung_pwm_matches[] = {
{ .compatible = "samsung,exynos4210-pwm", .data = &s5p64x0_variant },
{},
};
+MODULE_DEVICE_TABLE(of, samsung_pwm_matches);
static int pwm_samsung_parse_dt(struct samsung_pwm_chip *chip)
{
--
2.1.4
On 14.05.2015 09:32, Javier Martinez Canillas wrote:
> If the pwm-samsung driver is built as a module, modalias information is
> not filled so the module is not autoloaded. Use the MODULE_DEVICE_TABLE()
> macro to export the OF device ID so the module contains that information.
>
> Signed-off-by: Javier Martinez Canillas <[email protected]>
Reviewed-by: Krzysztof Kozlowski <[email protected]>
I think many other Maxim/S[25]M drivers for Samsung boards may also be
affected... Probably they should also be updated.
Best regards,
Krzysztof
Hello Krzysztof,
On 05/14/2015 02:37 AM, Krzysztof Kozlowski wrote:
> On 14.05.2015 09:32, Javier Martinez Canillas wrote:
>> If the pwm-samsung driver is built as a module, modalias information is
>> not filled so the module is not autoloaded. Use the MODULE_DEVICE_TABLE()
>> macro to export the OF device ID so the module contains that information.
>>
>> Signed-off-by: Javier Martinez Canillas <[email protected]>
>
> Reviewed-by: Krzysztof Kozlowski <[email protected]>
>
> I think many other Maxim/S[25]M drivers for Samsung boards may also be
> affected... Probably they should also be updated.
>
Yeah, I detected these since I'm preparing a series to reduce the delta
between exynos_defconfig and multi_v7_defconfig. And found these issues
since current multi_v7 policy is to build as much as possible as a module.
I think is unfortunate how many drivers are not providing proper module
aliases information and so building them as a module is less useful since
user-space can't associate the module with the modalias uevents to autoload.
Anyway, I'll take a look for other drivers and see if I can post similar
patches but now at least all the peripherals in the Exynos5 Chromebooks
are working when their drivers are built as a module.
> Best regards,
> Krzysztof
>
Best regards,
Javier
Hello Thierry,
On 05/14/2015 02:37 AM, Krzysztof Kozlowski wrote:
> On 14.05.2015 09:32, Javier Martinez Canillas wrote:
>> If the pwm-samsung driver is built as a module, modalias information is
>> not filled so the module is not autoloaded. Use the MODULE_DEVICE_TABLE()
>> macro to export the OF device ID so the module contains that information.
>>
>> Signed-off-by: Javier Martinez Canillas <[email protected]>
>
> Reviewed-by: Krzysztof Kozlowski <[email protected]>
>
>
Any comments on this patch?
Best regards,
Javier
On Thu, May 14, 2015 at 02:32:31AM +0200, Javier Martinez Canillas wrote:
> If the pwm-samsung driver is built as a module, modalias information is
> not filled so the module is not autoloaded. Use the MODULE_DEVICE_TABLE()
> macro to export the OF device ID so the module contains that information.
>
> Signed-off-by: Javier Martinez Canillas <[email protected]>
> ---
> drivers/pwm/pwm-samsung.c | 1 +
> 1 file changed, 1 insertion(+)
Applied, thanks.
Thierry