2022-03-17 05:40:48

by Rafael J. Wysocki

Subject: [PATCH v1 0/2] cpuidle: intel_idle: Kerneldoc update and cleanup

Hi All,

The following patches fix a kerneldoc comment and clean up whitespace in
intel_idle.

Please refer to the patch changelogs for details.

Thanks!

2022-03-17 06:21:22

by Rafael J. Wysocki

Subject: [PATCH v1 1/2] cpuidle: intel_idle: Update intel_idle() kerneldoc comment

From: Rafael J. Wysocki <[email protected]>

Commit bf9282dc26e7 ("cpuidle: Make CPUIDLE_FLAG_TLB_FLUSHED generic")
moved the leave_mm() call away from intel_idle(), but it didn't update
its kerneldoc comment accordingly, so do that now.

Fixes: bf9282dc26e7 ("cpuidle: Make CPUIDLE_FLAG_TLB_FLUSHED generic")
Signed-off-by: Rafael J. Wysocki <[email protected]>
---
drivers/idle/intel_idle.c | 3 ---
1 file changed, 3 deletions(-)

Index: linux-pm/drivers/idle/intel_idle.c
===================================================================
--- linux-pm.orig/drivers/idle/intel_idle.c
+++ linux-pm/drivers/idle/intel_idle.c
@@ -122,9 +122,6 @@ static unsigned int mwait_substates __in
* If the local APIC timer is not known to be reliable in the target idle state,
* enable one-shot tick broadcasting for the target CPU before executing MWAIT.
*
- * Optionally call leave_mm() for the target CPU upfront to avoid wakeups due to
- * flushing user TLBs.
- *
* Must be called under local_irq_disable().
*/
static __cpuidle int intel_idle(struct cpuidle_device *dev,

2022-03-17 19:49:09

by Rafael J. Wysocki

Subject: Re: [PATCH v1 1/2] cpuidle: intel_idle: Update intel_idle() kerneldoc comment

On Tue, Mar 15, 2022 at 8:37 PM Rafael J. Wysocki <[email protected]> wrote:
>
> From: Rafael J. Wysocki <[email protected]>
>
> Commit bf9282dc26e7 ("cpuidle: Make CPUIDLE_FLAG_TLB_FLUSHED generic")
> moved the leave_mm() call away from intel_idle(), but it didn't update
> its kerneldoc comment accordingly, so do that now.
>
> Fixes: bf9282dc26e7 ("cpuidle: Make CPUIDLE_FLAG_TLB_FLUSHED generic")
> Signed-off-by: Rafael J. Wysocki <[email protected]>
> ---
> drivers/idle/intel_idle.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> Index: linux-pm/drivers/idle/intel_idle.c
> ===================================================================
> --- linux-pm.orig/drivers/idle/intel_idle.c
> +++ linux-pm/drivers/idle/intel_idle.c
> @@ -122,9 +122,6 @@ static unsigned int mwait_substates __in
> * If the local APIC timer is not known to be reliable in the target idle state,
> * enable one-shot tick broadcasting for the target CPU before executing MWAIT.
> *
> - * Optionally call leave_mm() for the target CPU upfront to avoid wakeups due to
> - * flushing user TLBs.
> - *
> * Must be called under local_irq_disable().
> */
> static __cpuidle int intel_idle(struct cpuidle_device *dev,
>

Assuming no objections, so applied.