2015-05-18 17:54:46

by Fabian Frédérick

Subject: [PATCH 1/1 linux-next] omap_vout: use swap() in omapvid_init()

Use kernel.h macro definition.

Signed-off-by: Fabian Frederick <[email protected]>
---
drivers/media/platform/omap/omap_vout.c | 10 +++-------
1 file changed, 3 insertions(+), 7 deletions(-)

diff --git a/drivers/media/platform/omap/omap_vout.c b/drivers/media/platform/omap/omap_vout.c
index 17b189a..f09c5f1 100644
--- a/drivers/media/platform/omap/omap_vout.c
+++ b/drivers/media/platform/omap/omap_vout.c
@@ -445,7 +445,7 @@ static int omapvid_init(struct omap_vout_device *vout, u32 addr)
int ret = 0, i;
struct v4l2_window *win;
struct omap_overlay *ovl;
- int posx, posy, outw, outh, temp;
+ int posx, posy, outw, outh;
struct omap_video_timings *timing;
struct omapvideo_info *ovid = &vout->vid_info;

@@ -468,9 +468,7 @@ static int omapvid_init(struct omap_vout_device *vout, u32 addr)
/* Invert the height and width for 90
* and 270 degree rotation
*/
- temp = outw;
- outw = outh;
- outh = temp;
+ swap(outw, outh);
posy = (timing->y_res - win->w.width) - win->w.left;
posx = win->w.top;
break;
@@ -481,9 +479,7 @@ static int omapvid_init(struct omap_vout_device *vout, u32 addr)
break;

case dss_rotation_270_degree:
- temp = outw;
- outw = outh;
- outh = temp;
+ swap(outw, outh);
posy = win->w.left;
posx = (timing->x_res - win->w.height) - win->w.top;
break;
--
2.4.0

2015-05-18 18:21:04

by Vaibhav Hiremath

Subject: Re: [PATCH 1/1 linux-next] omap_vout: use swap() in omapvid_init()

On Monday 18 May 2015 11:24 PM, Fabian Frederick wrote:
> Use kernel.h macro definition.
>
> Signed-off-by: Fabian Frederick <[email protected]>
> ---
> drivers/media/platform/omap/omap_vout.c | 10 +++-------
> 1 file changed, 3 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/media/platform/omap/omap_vout.c b/drivers/media/platform/omap/omap_vout.c
> index 17b189a..f09c5f1 100644
> --- a/drivers/media/platform/omap/omap_vout.c
> +++ b/drivers/media/platform/omap/omap_vout.c
> @@ -445,7 +445,7 @@ static int omapvid_init(struct omap_vout_device *vout, u32 addr)
> int ret = 0, i;
> struct v4l2_window *win;
> struct omap_overlay *ovl;
> - int posx, posy, outw, outh, temp;
> + int posx, posy, outw, outh;
> struct omap_video_timings *timing;
> struct omapvideo_info *ovid = &vout->vid_info;
>
> @@ -468,9 +468,7 @@ static int omapvid_init(struct omap_vout_device *vout, u32 addr)
> /* Invert the height and width for 90
> * and 270 degree rotation
> */
> - temp = outw;
> - outw = outh;
> - outh = temp;
> + swap(outw, outh);
> posy = (timing->y_res - win->w.width) - win->w.left;
> posx = win->w.top;
> break;
> @@ -481,9 +479,7 @@ static int omapvid_init(struct omap_vout_device *vout, u32 addr)
> break;
>
> case dss_rotation_270_degree:
> - temp = outw;
> - outw = outh;
> - outh = temp;
> + swap(outw, outh);
> posy = win->w.left;
> posx = (timing->x_res - win->w.height) - win->w.top;
> break;
>


Curious to know,
How do you test this? Do you have any OMAP2/3 or AM335x board?
Does this driver still works?

Thanks,
Vaibhav

2015-05-18 18:31:43

by Fabian Frédérick

Subject: Re: [PATCH 1/1 linux-next] omap_vout: use swap() in omapvid_init()

> On 18 May 2015 at 20:20 Vaibhav Hiremath <[email protected]> wrote:
>
>
>
>
> On Monday 18 May 2015 11:24 PM, Fabian Frederick wrote:
> > Use kernel.h macro definition.
> >
> > Signed-off-by: Fabian Frederick <[email protected]>
> > ---
> >   drivers/media/platform/omap/omap_vout.c | 10 +++-------
> >   1 file changed, 3 insertions(+), 7 deletions(-)
> >
> > diff --git a/drivers/media/platform/omap/omap_vout.c
> > b/drivers/media/platform/omap/omap_vout.c
> > index 17b189a..f09c5f1 100644
> > --- a/drivers/media/platform/omap/omap_vout.c
> > +++ b/drivers/media/platform/omap/omap_vout.c
> > @@ -445,7 +445,7 @@ static int omapvid_init(struct omap_vout_device *vout,
> > u32 addr)
> >     int ret = 0, i;
> >     struct v4l2_window *win;
> >     struct omap_overlay *ovl;
> > -   int posx, posy, outw, outh, temp;
> > +   int posx, posy, outw, outh;
> >     struct omap_video_timings *timing;
> >     struct omapvideo_info *ovid = &vout->vid_info;
> >
> > @@ -468,9 +468,7 @@ static int omapvid_init(struct omap_vout_device *vout,
> > u32 addr)
> >                     /* Invert the height and width for 90
> >                      * and 270 degree rotation
> >                      */
> > -                   temp = outw;
> > -                   outw = outh;
> > -                   outh = temp;
> > +                   swap(outw, outh);
> >                     posy = (timing->y_res - win->w.width) - win->w.left;
> >                     posx = win->w.top;
> >                     break;
> > @@ -481,9 +479,7 @@ static int omapvid_init(struct omap_vout_device *vout,
> > u32 addr)
> >                     break;
> >
> >             case dss_rotation_270_degree:
> > -                   temp = outw;
> > -                   outw = outh;
> > -                   outh = temp;
> > +                   swap(outw, outh);
> >                     posy = win->w.left;
> >                     posx = (timing->x_res - win->w.height) - win->w.top;
> >                     break;
> >
>
>
> Curious to know,
> How do you test this? Do you have any OMAP2/3 or AM335x board?
> Does this driver still works?

Hello Vaibhav,

   Unfortunately I can't test it.
 
Regards,
Fabian
>
> Thanks,
> Vaibhav

2015-05-19 04:50:42

by Vaibhav Hiremath

Subject: Re: [PATCH 1/1 linux-next] omap_vout: use swap() in omapvid_init()

On Tuesday 19 May 2015 12:01 AM, Fabian Frederick wrote:
>
>
>> On 18 May 2015 at 20:20 Vaibhav Hiremath <[email protected]> wrote:
>>
>>
>>
>>
>> On Monday 18 May 2015 11:24 PM, Fabian Frederick wrote:
>>> Use kernel.h macro definition.
>>>
>>> Signed-off-by: Fabian Frederick <[email protected]>
>>> ---
>>> drivers/media/platform/omap/omap_vout.c | 10 +++-------
>>> 1 file changed, 3 insertions(+), 7 deletions(-)
>>>
>>> diff --git a/drivers/media/platform/omap/omap_vout.c
>>> b/drivers/media/platform/omap/omap_vout.c
>>> index 17b189a..f09c5f1 100644
>>> --- a/drivers/media/platform/omap/omap_vout.c
>>> +++ b/drivers/media/platform/omap/omap_vout.c
>>> @@ -445,7 +445,7 @@ static int omapvid_init(struct omap_vout_device *vout,
>>> u32 addr)
>>> int ret = 0, i;
>>> struct v4l2_window *win;
>>> struct omap_overlay *ovl;
>>> - int posx, posy, outw, outh, temp;
>>> + int posx, posy, outw, outh;
>>> struct omap_video_timings *timing;
>>> struct omapvideo_info *ovid = &vout->vid_info;
>>>
>>> @@ -468,9 +468,7 @@ static int omapvid_init(struct omap_vout_device *vout,
>>> u32 addr)
>>> /* Invert the height and width for 90
>>> * and 270 degree rotation
>>> */
>>> - temp = outw;
>>> - outw = outh;
>>> - outh = temp;
>>> + swap(outw, outh);
>>> posy = (timing->y_res - win->w.width) - win->w.left;
>>> posx = win->w.top;
>>> break;
>>> @@ -481,9 +479,7 @@ static int omapvid_init(struct omap_vout_device *vout,
>>> u32 addr)
>>> break;
>>>
>>> case dss_rotation_270_degree:
>>> - temp = outw;
>>> - outw = outh;
>>> - outh = temp;
>>> + swap(outw, outh);
>>> posy = win->w.left;
>>> posx = (timing->x_res - win->w.height) - win->w.top;
>>> break;
>>>
>>
>>
>> Curious to know,
>> How do you test this? Do you have any OMAP2/3 or AM335x board?
>> Does this driver still works?
>
> Hello Vaibhav,
>
> Unfortunately I can't test it.
>

Thats what I expected.

I am doubtful that anyone still uses this driver.
With DRM framework support, I see very little use of this driver.

Also there are some hacks regarding buffer management, that need to be
fixed if at all we want to support it.

I would really want to slowly kill this driver, if no one uses it.

Thanks,
Vaibhav