2015-05-20 06:29:48

by Stephen Rothwell

[permalink] [raw]

Subject: linux-next: build warnings after merge of the usb-gadget tree

---

Hi Felipe,

After merging the usb-gadget tree, today's linux-next build (x86_64
allmodconfig) produced these warnings:

drivers/usb/gadget/function/rndis.c: In function 'rndis_proc_write':
drivers/usb/gadget/function/rndis.c:1147:4: warning: passing argument 1 of 'rndis_signal_connect' makes pointer from integer without a cast
rndis_signal_connect(p->confignr);
^
drivers/usb/gadget/function/rndis.c:748:5: note: expected 'struct rndis_params *' but argument is of type 'u8'
int rndis_signal_connect(struct rndis_params *params)
^
drivers/usb/gadget/function/rndis.c:1151:4: warning: passing argument 1 of 'rndis_signal_disconnect' makes pointer from integer without a cast
rndis_signal_disconnect(p->confignr);
^
drivers/usb/gadget/function/rndis.c:755:5: note: expected 'struct rndis_params *' but argument is of type 'u8'
int rndis_signal_disconnect(struct rndis_params *params)
^

Probably caused by commit 83210e59ee15 ("usb: gadget: rndis: use
rndis_params instead of configNr").

--
Cheers,
Stephen Rothwell [email protected]

---

Attachments:

(No filename) (819.00 B)
OpenPGP digital signature

2015-05-20 07:18:52

by Andrzej Pietrasiewicz

[permalink] [raw]

Subject: Re: linux-next: build warnings after merge of the usb-gadget tree

---

W dniu 20.05.2015 o 08:29, Stephen Rothwell pisze:
> Hi Felipe,
>
> After merging the usb-gadget tree, today's linux-next build (x86_64
> allmodconfig) produced these warnings:
>
> drivers/usb/gadget/function/rndis.c: In function 'rndis_proc_write':
> drivers/usb/gadget/function/rndis.c:1147:4: warning: passing argument 1 of 'rndis_signal_connect' makes pointer from integer without a cast
> rndis_signal_connect(p->confignr);
> ^
> drivers/usb/gadget/function/rndis.c:748:5: note: expected 'struct rndis_params *' but argument is of type 'u8'
> int rndis_signal_connect(struct rndis_params *params)
> ^
> drivers/usb/gadget/function/rndis.c:1151:4: warning: passing argument 1 of 'rndis_signal_disconnect' makes pointer from integer without a cast
> rndis_signal_disconnect(p->confignr);
> ^
> drivers/usb/gadget/function/rndis.c:755:5: note: expected 'struct rndis_params *' but argument is of type 'u8'
> int rndis_signal_disconnect(struct rndis_params *params)
> ^
>
> Probably caused by commit 83210e59ee15 ("usb: gadget: rndis: use
> rndis_params instead of configNr").
>
There is already a patch series for that:

http://www.spinics.net/lists/linux-usb/msg125003.html

AP