2015-05-21 02:18:52

by Krzysztof Kozlowski

[permalink] [raw]
Subject: [PATCH 1/2] ARM: dts: exynos4: Remove obsolete MIPI DPHY 'reg' property

Since e4b3d38088df ("phy: exynos-video-mipi: Fix regression by adding
support for PMU regmap") the Exynos PMU driver provides regmap to access
the MIPI DPHY registers. The MIPI DPHY node uses a phandle to syscon to
get this regmap. The 'reg' field is obsolete.

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
arch/arm/boot/dts/exynos4.dtsi | 1 -
1 file changed, 1 deletion(-)

diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi
index 1c74c1296ab7..6e7f0b4afa84 100644
--- a/arch/arm/boot/dts/exynos4.dtsi
+++ b/arch/arm/boot/dts/exynos4.dtsi
@@ -78,7 +78,6 @@

mipi_phy: video-phy@10020710 {
compatible = "samsung,s5pv210-mipi-video-phy";
- reg = <0x10020710 8>;
#phy-cells = <1>;
syscon = <&pmu_system_controller>;
};
--
1.9.1


2015-05-21 02:19:08

by Krzysztof Kozlowski

[permalink] [raw]
Subject: [PATCH 2/2] ARM: dts: exynos4415: Add syscon property to the MIPI DPHY

Since e4b3d38088df ("phy: exynos-video-mipi: Fix regression by adding
support for PMU regmap") the Exynos PMU driver provides regmap to access
the MIPI DPHY registers. The MIPI DPHY driver accesses this regmap
through syscon phandle.

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
arch/arm/boot/dts/exynos4415.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/exynos4415.dtsi b/arch/arm/boot/dts/exynos4415.dtsi
index 186cb8465683..6a83d7999d8a 100644
--- a/arch/arm/boot/dts/exynos4415.dtsi
+++ b/arch/arm/boot/dts/exynos4415.dtsi
@@ -124,8 +124,8 @@

mipi_phy: video-phy@10020710 {
compatible = "samsung,s5pv210-mipi-video-phy";
- reg = <0x10020710 8>;
#phy-cells = <1>;
+ syscon = <&pmu_system_controller>;
};

pd_cam: cam-power-domain@10024000 {
--
1.9.1

2015-05-21 07:23:28

by Javier Martinez Canillas

[permalink] [raw]
Subject: Re: [PATCH 1/2] ARM: dts: exynos4: Remove obsolete MIPI DPHY 'reg' property

Hello Krzysztof,

On Thu, May 21, 2015 at 4:18 AM, Krzysztof Kozlowski
<[email protected]> wrote:
> Since e4b3d38088df ("phy: exynos-video-mipi: Fix regression by adding
> support for PMU regmap") the Exynos PMU driver provides regmap to access
> the MIPI DPHY registers. The MIPI DPHY node uses a phandle to syscon to
> get this regmap. The 'reg' field is obsolete.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
> arch/arm/boot/dts/exynos4.dtsi | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi
> index 1c74c1296ab7..6e7f0b4afa84 100644
> --- a/arch/arm/boot/dts/exynos4.dtsi
> +++ b/arch/arm/boot/dts/exynos4.dtsi
> @@ -78,7 +78,6 @@
>
> mipi_phy: video-phy@10020710 {
> compatible = "samsung,s5pv210-mipi-video-phy";
> - reg = <0x10020710 8>;
> #phy-cells = <1>;
> syscon = <&pmu_system_controller>;
> };

Indeed, is even removed from the DT binding so this is clearly a left over.

Reviewed-by: Javier Martinez Canillas <[email protected]>

Best regards,
Javier

2015-05-21 07:24:17

by Javier Martinez Canillas

[permalink] [raw]
Subject: Re: [PATCH 2/2] ARM: dts: exynos4415: Add syscon property to the MIPI DPHY

Hello Krzysztof,

On Thu, May 21, 2015 at 4:18 AM, Krzysztof Kozlowski
<[email protected]> wrote:
> Since e4b3d38088df ("phy: exynos-video-mipi: Fix regression by adding
> support for PMU regmap") the Exynos PMU driver provides regmap to access
> the MIPI DPHY registers. The MIPI DPHY driver accesses this regmap
> through syscon phandle.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
> arch/arm/boot/dts/exynos4415.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/exynos4415.dtsi b/arch/arm/boot/dts/exynos4415.dtsi
> index 186cb8465683..6a83d7999d8a 100644
> --- a/arch/arm/boot/dts/exynos4415.dtsi
> +++ b/arch/arm/boot/dts/exynos4415.dtsi
> @@ -124,8 +124,8 @@
>
> mipi_phy: video-phy@10020710 {
> compatible = "samsung,s5pv210-mipi-video-phy";
> - reg = <0x10020710 8>;
> #phy-cells = <1>;
> + syscon = <&pmu_system_controller>;
> };
>
> pd_cam: cam-power-domain@10024000 {
> --

Reviewed-by: Javier Martinez Canillas <[email protected]>

Best regards,
Javier

2015-05-23 02:20:16

by Kukjin Kim

[permalink] [raw]
Subject: Re: [PATCH 1/2] ARM: dts: exynos4: Remove obsolete MIPI DPHY 'reg' property

On 05/21/15 16:23, Javier Martinez Canillas wrote:
> Hello Krzysztof,
>
> On Thu, May 21, 2015 at 4:18 AM, Krzysztof Kozlowski
> <[email protected]> wrote:
>> Since e4b3d38088df ("phy: exynos-video-mipi: Fix regression by adding
>> support for PMU regmap") the Exynos PMU driver provides regmap to access
>> the MIPI DPHY registers. The MIPI DPHY node uses a phandle to syscon to
>> get this regmap. The 'reg' field is obsolete.
>>
>> Signed-off-by: Krzysztof Kozlowski <[email protected]>
>> ---
>> arch/arm/boot/dts/exynos4.dtsi | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi
>> index 1c74c1296ab7..6e7f0b4afa84 100644
>> --- a/arch/arm/boot/dts/exynos4.dtsi
>> +++ b/arch/arm/boot/dts/exynos4.dtsi
>> @@ -78,7 +78,6 @@
>>
>> mipi_phy: video-phy@10020710 {
>> compatible = "samsung,s5pv210-mipi-video-phy";
>> - reg = <0x10020710 8>;
>> #phy-cells = <1>;
>> syscon = <&pmu_system_controller>;
>> };
>
> Indeed, is even removed from the DT binding so this is clearly a left over.
>
> Reviewed-by: Javier Martinez Canillas <[email protected]>
>
Thanks, applied this series.

- Kukjin