2024-05-20 22:27:09

by Rob Herring (Arm)

Subject: [PATCH] dt-bindings: clock: milbeaut: Drop providers and consumers from example

Convention for examples is to only show what's covered by the binding,
so drop the consumer "socionext,milbeaut-usio-uart" and input clock
provider "fixed-clock" from the example. "socionext,milbeaut-usio-uart"
is also not documented by a schema which caused a warning.

Signed-off-by: Rob Herring (Arm) <[email protected]>
---
.../bindings/clock/milbeaut-clock.yaml | 29 +------------------
1 file changed, 1 insertion(+), 28 deletions(-)

diff --git a/Documentation/devicetree/bindings/clock/milbeaut-clock.yaml b/Documentation/devicetree/bindings/clock/milbeaut-clock.yaml
index 0af1c569eb32..d786f1e2d007 100644
--- a/Documentation/devicetree/bindings/clock/milbeaut-clock.yaml
+++ b/Documentation/devicetree/bindings/clock/milbeaut-clock.yaml
@@ -40,38 +40,11 @@ required:
additionalProperties: false

examples:
- # Clock controller node:
- |
- m10v-clk-ctrl@1d021000 {
+ clock-controller@1d021000 {
compatible = "socionext,milbeaut-m10v-ccu";
reg = <0x1d021000 0x4000>;
#clock-cells = <1>;
clocks = <&clki40mhz>;
};
-
- # Required an external clock for Clock controller node:
- - |
- clocks {
- clki40mhz: clki40mhz {
- compatible = "fixed-clock";
- #clock-cells = <0>;
- clock-frequency = <40000000>;
- };
- /* other clocks */
- };
-
- # The clock consumer shall specify the desired clock-output of the clock
- # controller as below by specifying output-id in its "clk" phandle cell.
- # 2: uart
- # 4: 32-bit timer
- # 7: UHS-I/II
- - |
- serial@1e700010 {
- compatible = "socionext,milbeaut-usio-uart";
- reg = <0x1e700010 0x10>;
- interrupts = <0 141 0x4>, <0 149 0x4>;
- interrupt-names = "rx", "tx";
- clocks = <&clk 2>;
- };
-
...
--
2.43.0

2024-05-21 10:25:57

by Krzysztof Kozlowski

Subject: Re: [PATCH] dt-bindings: clock: milbeaut: Drop providers and consumers from example

On 21/05/2024 00:26, Rob Herring (Arm) wrote:
> Convention for examples is to only show what's covered by the binding,
> so drop the consumer "socionext,milbeaut-usio-uart" and input clock
> provider "fixed-clock" from the example. "socionext,milbeaut-usio-uart"
> is also not documented by a schema which caused a warning.
>
> Signed-off-by: Rob Herring (Arm) <[email protected]>
> ---

Reviewed-by: Krzysztof Kozlowski <[email protected]>

Best regards,
Krzysztof

2024-06-03 23:34:31

by Stephen Boyd

Subject: Re: [PATCH] dt-bindings: clock: milbeaut: Drop providers and consumers from example

Quoting Rob Herring (Arm) (2024-05-20 15:26:45)
> Convention for examples is to only show what's covered by the binding,
> so drop the consumer "socionext,milbeaut-usio-uart" and input clock
> provider "fixed-clock" from the example. "socionext,milbeaut-usio-uart"
> is also not documented by a schema which caused a warning.
>
> Signed-off-by: Rob Herring (Arm) <[email protected]>
> ---

Applied to clk-next