2024-04-13 13:46:31

by Christophe JAILLET

[permalink] [raw]
Subject: [PATCH] clk: gemini: Remove an unused field in struct clk_gemini_pci

In "struct clk_gemini_pci", the 'rate' field is unused.

Remove it.

Found with cppcheck, unusedStructMember.

Signed-off-by: Christophe JAILLET <[email protected]>
---
Compile tested only.

Apparently, it has never been used. It is not a left-over from a
refactoring.
---
drivers/clk/clk-gemini.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/clk/clk-gemini.c b/drivers/clk/clk-gemini.c
index ba0ff01bf4dc..856b008e07c6 100644
--- a/drivers/clk/clk-gemini.c
+++ b/drivers/clk/clk-gemini.c
@@ -67,12 +67,10 @@ struct gemini_gate_data {
* struct clk_gemini_pci - Gemini PCI clock
* @hw: corresponding clock hardware entry
* @map: regmap to access the registers
- * @rate: current rate
*/
struct clk_gemini_pci {
struct clk_hw hw;
struct regmap *map;
- unsigned long rate;
};

/**
--
2.44.0



2024-04-20 01:58:42

by Stephen Boyd

[permalink] [raw]
Subject: Re: [PATCH] clk: gemini: Remove an unused field in struct clk_gemini_pci

Quoting Christophe JAILLET (2024-04-13 06:46:09)
> In "struct clk_gemini_pci", the 'rate' field is unused.
>
> Remove it.
>
> Found with cppcheck, unusedStructMember.
>
> Signed-off-by: Christophe JAILLET <[email protected]>
> ---

Applied to clk-next

2024-04-20 02:06:53

by Stephen Boyd

[permalink] [raw]
Subject: Re: [PATCH] clk: gemini: Remove an unused field in struct clk_gemini_pci

Quoting Christophe JAILLET (2024-04-13 06:46:09)
> In "struct clk_gemini_pci", the 'rate' field is unused.
>
> Remove it.
>
> Found with cppcheck, unusedStructMember.
>
> Signed-off-by: Christophe JAILLET <[email protected]>
> ---

Applied to clk-next