2015-06-02 15:26:20

by Shuah Khan

[permalink] [raw]
Subject: Re: [RESEND PATCH 3/3] Add tests for lock on fault

On 05/29/2015 08:13 AM, Eric B Munson wrote:
> Test the mmap() flag, the mlockall() flag, and ensure that mlock limits
> are respected. Note that the limit test needs to be run a normal user.
>
> Signed-off-by: Eric B Munson <[email protected]>
> Cc: Shuah Khan <[email protected]>
> Cc: [email protected]
> Cc: [email protected]
> Cc: [email protected]
> ---
> tools/testing/selftests/vm/Makefile | 8 +-
> tools/testing/selftests/vm/lock-on-fault.c | 145 ++++++++++++++++++++++++++++
> tools/testing/selftests/vm/on-fault-limit.c | 47 +++++++++
> tools/testing/selftests/vm/run_vmtests | 23 +++++
> 4 files changed, 222 insertions(+), 1 deletion(-)
> create mode 100644 tools/testing/selftests/vm/lock-on-fault.c
> create mode 100644 tools/testing/selftests/vm/on-fault-limit.c
>
> diff --git a/tools/testing/selftests/vm/Makefile b/tools/testing/selftests/vm/Makefile
> index a5ce953..32f3d20 100644
> --- a/tools/testing/selftests/vm/Makefile
> +++ b/tools/testing/selftests/vm/Makefile
> @@ -1,7 +1,13 @@
> # Makefile for vm selftests
>
> CFLAGS = -Wall
> -BINARIES = hugepage-mmap hugepage-shm map_hugetlb thuge-gen hugetlbfstest
> +BINARIES = hugepage-mmap
> +BINARIES += hugepage-shm
> +BINARIES += hugetlbfstest
> +BINARIES += lock-on-fault
> +BINARIES += map_hugetlb
> +BINARIES += on-fault-limit
> +BINARIES += thuge-gen
> BINARIES += transhuge-stress
>
> all: $(BINARIES)
> diff --git a/tools/testing/selftests/vm/lock-on-fault.c b/tools/testing/selftests/vm/lock-on-fault.c
> new file mode 100644
> index 0000000..e6a9688

Hi Eric,

Could you please make sure make kselftest run from kernel main
Makefile works and tools/testing/selftests/kselftest_install.sh
works. For now you have to be in tools/testing/selftests to run
kselftest_install.sh

thanks,
-- Shuah


--
Shuah Khan
Sr. Linux Kernel Developer
Open Source Innovation Group
Samsung Research America (Silicon Valley)
[email protected] | (970) 217-8978


2015-06-02 16:05:55

by Eric B Munson

[permalink] [raw]
Subject: Re: [RESEND PATCH 3/3] Add tests for lock on fault

On Tue, 02 Jun 2015, Shuah Khan wrote:

> On 05/29/2015 08:13 AM, Eric B Munson wrote:
> > Test the mmap() flag, the mlockall() flag, and ensure that mlock limits
> > are respected. Note that the limit test needs to be run a normal user.
> >
> > Signed-off-by: Eric B Munson <[email protected]>
> > Cc: Shuah Khan <[email protected]>
> > Cc: [email protected]
> > Cc: [email protected]
> > Cc: [email protected]
> > ---
> > tools/testing/selftests/vm/Makefile | 8 +-
> > tools/testing/selftests/vm/lock-on-fault.c | 145 ++++++++++++++++++++++++++++
> > tools/testing/selftests/vm/on-fault-limit.c | 47 +++++++++
> > tools/testing/selftests/vm/run_vmtests | 23 +++++
> > 4 files changed, 222 insertions(+), 1 deletion(-)
> > create mode 100644 tools/testing/selftests/vm/lock-on-fault.c
> > create mode 100644 tools/testing/selftests/vm/on-fault-limit.c
> >
> > diff --git a/tools/testing/selftests/vm/Makefile b/tools/testing/selftests/vm/Makefile
> > index a5ce953..32f3d20 100644
> > --- a/tools/testing/selftests/vm/Makefile
> > +++ b/tools/testing/selftests/vm/Makefile
> > @@ -1,7 +1,13 @@
> > # Makefile for vm selftests
> >
> > CFLAGS = -Wall
> > -BINARIES = hugepage-mmap hugepage-shm map_hugetlb thuge-gen hugetlbfstest
> > +BINARIES = hugepage-mmap
> > +BINARIES += hugepage-shm
> > +BINARIES += hugetlbfstest
> > +BINARIES += lock-on-fault
> > +BINARIES += map_hugetlb
> > +BINARIES += on-fault-limit
> > +BINARIES += thuge-gen
> > BINARIES += transhuge-stress
> >
> > all: $(BINARIES)
> > diff --git a/tools/testing/selftests/vm/lock-on-fault.c b/tools/testing/selftests/vm/lock-on-fault.c
> > new file mode 100644
> > index 0000000..e6a9688
>
> Hi Eric,
>
> Could you please make sure make kselftest run from kernel main
> Makefile works and tools/testing/selftests/kselftest_install.sh
> works. For now you have to be in tools/testing/selftests to run
> kselftest_install.sh
>

I am working on getting V2 ready, I will ensure these work and make any
necessary adjustments before sending V2 out.

Eric


Attachments:
(No filename) (2.03 kB)
signature.asc (819.00 B)
Digital signature
Download all attachments