2015-06-08 09:54:02

by Uwe Kleine-König

[permalink] [raw]
Subject: [PATCH] HSI: nokia-modem: use flags argument of devm_gpiod_get to set direction

Since 39b2bbe3d715 (gpio: add flags argument to gpiod_get*() functions)
which appeared in v3.17-rc1, the gpiod_get* functions take an additional
parameter that allows to specify direction and initial value for output.

Use this to simplify the driver. Furthermore this is one caller less
that stops us making the flags argument to gpiod_get*() mandatory.

Signed-off-by: Uwe Kleine-König <[email protected]>
---
drivers/hsi/clients/nokia-modem.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/drivers/hsi/clients/nokia-modem.c b/drivers/hsi/clients/nokia-modem.c
index bbb19231fa82..94670f2bb7d7 100644
--- a/drivers/hsi/clients/nokia-modem.c
+++ b/drivers/hsi/clients/nokia-modem.c
@@ -112,7 +112,8 @@ static int nokia_modem_gpio_probe(struct device *dev)
modem->gpio_amount = gpio_count;

for (i = 0; i < gpio_count; i++) {
- modem->gpios[i].gpio = devm_gpiod_get_index(dev, NULL, i);
+ modem->gpios[i].gpio = devm_gpiod_get_index(dev, NULL, i,
+ GPIOD_OUT_LOW);
if (IS_ERR(modem->gpios[i].gpio)) {
dev_err(dev, "Could not get gpio %d\n", i);
return PTR_ERR(modem->gpios[i].gpio);
@@ -125,10 +126,6 @@ static int nokia_modem_gpio_probe(struct device *dev)
return err;
}

- err = gpiod_direction_output(modem->gpios[i].gpio, 0);
- if (err)
- return err;
-
err = gpiod_export(modem->gpios[i].gpio, 0);
if (err)
return err;
--
2.1.4


2015-06-10 02:24:47

by Alexandre Courbot

[permalink] [raw]
Subject: Re: [PATCH] HSI: nokia-modem: use flags argument of devm_gpiod_get to set direction

On 06/08/2015 06:53 PM, Uwe Kleine-König wrote:
> Since 39b2bbe3d715 (gpio: add flags argument to gpiod_get*() functions)
> which appeared in v3.17-rc1, the gpiod_get* functions take an additional
> parameter that allows to specify direction and initial value for output.
>
> Use this to simplify the driver. Furthermore this is one caller less
> that stops us making the flags argument to gpiod_get*() mandatory.

Acked-by: Alexandre Courbot <[email protected]>

Thanks Uwe for taking care of this!

2015-06-10 12:58:06

by Linus Walleij

[permalink] [raw]
Subject: Re: [PATCH] HSI: nokia-modem: use flags argument of devm_gpiod_get to set direction

On Mon, Jun 8, 2015 at 11:53 AM, Uwe Kleine-König
<[email protected]> wrote:

> Since 39b2bbe3d715 (gpio: add flags argument to gpiod_get*() functions)
> which appeared in v3.17-rc1, the gpiod_get* functions take an additional
> parameter that allows to specify direction and initial value for output.
>
> Use this to simplify the driver. Furthermore this is one caller less
> that stops us making the flags argument to gpiod_get*() mandatory.
>
> Signed-off-by: Uwe Kleine-König <[email protected]>

Acked-by: Linus Walleij <[email protected]>

Yours,
Linus Walleij

2015-06-10 14:05:24

by Sebastian Reichel

[permalink] [raw]
Subject: Re: [PATCH] HSI: nokia-modem: use flags argument of devm_gpiod_get to set direction

Hi,

On Mon, Jun 08, 2015 at 11:53:45AM +0200, Uwe Kleine-K?nig wrote:
> Since 39b2bbe3d715 (gpio: add flags argument to gpiod_get*() functions)
> which appeared in v3.17-rc1, the gpiod_get* functions take an additional
> parameter that allows to specify direction and initial value for output.
>
> Use this to simplify the driver. Furthermore this is one caller less
> that stops us making the flags argument to gpiod_get*() mandatory.

Thanks, queued.

-- Sebastian

Attachments:
(No filename) (469.00 B)
 signature.asc (819.00 B)
Digital signature Download all attachments