2023-07-18 21:09:19

by Eric Van Hensbergen

Subject: [PATCH v2 1/4] fs/9p: remove unnecessary and overrestrictive check

This eliminates a check for shared that was overrestrictive and
duplicated a check in generic_file_readonly_mmap.

Reviewed-by: Dominique Martinet <[email protected]>
Reviewed-by: Christian Schoenebeck <[email protected]>
Signed-off-by: Eric Van Hensbergen <[email protected]>
---
fs/9p/vfs_file.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/fs/9p/vfs_file.c b/fs/9p/vfs_file.c
index 2996fb00387fa..bda3abd6646b8 100644
--- a/fs/9p/vfs_file.c
+++ b/fs/9p/vfs_file.c
@@ -506,8 +506,6 @@ v9fs_file_mmap(struct file *filp, struct vm_area_struct *vma)

if (!(v9ses->cache & CACHE_WRITEBACK)) {
p9_debug(P9_DEBUG_CACHE, "(no mmap mode)");
- if (vma->vm_flags & VM_MAYSHARE)
- return -ENODEV;
invalidate_inode_pages2(filp->f_mapping);
return generic_file_readonly_mmap(filp, vma);
}

--
2.39.2

2023-07-19 13:50:39

by Christian Schoenebeck

Subject: Re: [PATCH v2 1/4] fs/9p: remove unnecessary and overrestrictive check

On Tuesday, July 18, 2023 10:50:15 PM CEST Eric Van Hensbergen wrote:
> This eliminates a check for shared that was overrestrictive and
> duplicated a check in generic_file_readonly_mmap.
>
> Reviewed-by: Dominique Martinet <[email protected]>
> Reviewed-by: Christian Schoenebeck <[email protected]>
> Signed-off-by: Eric Van Hensbergen <[email protected]>
> ---
> fs/9p/vfs_file.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/fs/9p/vfs_file.c b/fs/9p/vfs_file.c
> index 2996fb00387fa..bda3abd6646b8 100644
> --- a/fs/9p/vfs_file.c
> +++ b/fs/9p/vfs_file.c
> @@ -506,8 +506,6 @@ v9fs_file_mmap(struct file *filp, struct vm_area_struct *vma)
>
> if (!(v9ses->cache & CACHE_WRITEBACK)) {
> p9_debug(P9_DEBUG_CACHE, "(no mmap mode)");

"(r/o mmap mode)" ?

> - if (vma->vm_flags & VM_MAYSHARE)
> - return -ENODEV;
> invalidate_inode_pages2(filp->f_mapping);
> return generic_file_readonly_mmap(filp, vma);
> }
>
>