2015-06-20 20:13:47

by Luis de Bethencourt

Subject: [PATCH] staging: comedi: don't split Author string

fixes checkpatch.pl WARNING: quoted string split across lines

+MODULE_AUTHOR("David A. Schleef <[email protected]>, "
+ "Frank Mori Hess <[email protected]>");

total: 0 errors, 1 warnings, 114 lines checked

Modules with multiple authors have a MODULE_AUTHOR line for each one.

Signed-off-by: Luis de Bethencourt <[email protected]>
---
drivers/staging/comedi/drivers/das08_cs.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/comedi/drivers/das08_cs.c b/drivers/staging/comedi/drivers/das08_cs.c
index 93fab68..9c02b17 100644
--- a/drivers/staging/comedi/drivers/das08_cs.c
+++ b/drivers/staging/comedi/drivers/das08_cs.c
@@ -108,7 +108,7 @@ static struct pcmcia_driver das08_cs_driver = {
};
module_comedi_pcmcia_driver(driver_das08_cs, das08_cs_driver);

-MODULE_AUTHOR("David A. Schleef <[email protected]>, "
- "Frank Mori Hess <[email protected]>");
+MODULE_AUTHOR("David A. Schleef <[email protected]>");
+MODULE_AUTHOR("Frank Mori Hess <[email protected]>");
MODULE_DESCRIPTION("Comedi driver for ComputerBoards DAS-08 PCMCIA boards");
MODULE_LICENSE("GPL");
--
2.1.0

2015-06-22 11:44:48

by Ian Abbott

Subject: Re: [PATCH] staging: comedi: don't split Author string

On 20/06/15 21:14, Luis de Bethencourt wrote:
> fixes checkpatch.pl WARNING: quoted string split across lines
>
> +MODULE_AUTHOR("David A. Schleef <[email protected]>, "
> + "Frank Mori Hess <[email protected]>");
>
> total: 0 errors, 1 warnings, 114 lines checked
>
> Modules with multiple authors have a MODULE_AUTHOR line for each one.
>
> Signed-off-by: Luis de Bethencourt <[email protected]>
> ---
> drivers/staging/comedi/drivers/das08_cs.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/das08_cs.c b/drivers/staging/comedi/drivers/das08_cs.c
> index 93fab68..9c02b17 100644
> --- a/drivers/staging/comedi/drivers/das08_cs.c
> +++ b/drivers/staging/comedi/drivers/das08_cs.c
> @@ -108,7 +108,7 @@ static struct pcmcia_driver das08_cs_driver = {
> };
> module_comedi_pcmcia_driver(driver_das08_cs, das08_cs_driver);
>
> -MODULE_AUTHOR("David A. Schleef <[email protected]>, "
> - "Frank Mori Hess <[email protected]>");
> +MODULE_AUTHOR("David A. Schleef <[email protected]>");
> +MODULE_AUTHOR("Frank Mori Hess <[email protected]>");
> MODULE_DESCRIPTION("Comedi driver for ComputerBoards DAS-08 PCMCIA boards");
> MODULE_LICENSE("GPL");
>

Okay, it would be nice if the patch subject line mentioned the name of
the module, but this is the only one in COMEDI with a split author line.

Reviewed-by: Ian Abbott <[email protected]>

--
-=( Ian Abbott @ MEV Ltd. E-mail: <[email protected]> )=-
-=( Web: http://www.mev.co.uk/ )=-