2015-06-22 13:26:32

by Maninder Singh

Subject: [Resend PATCH 1/1] kernel/gcov/fs.c: Use kzalloc for allocating one thing

Use kzalloc rather than kcalloc(1.. for allocation
of one thing.

Signed-off-by: Maninder Singh <[email protected]>
Reviewed-by: Vaneet Narang <[email protected]>
---
kernel/gcov/fs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/gcov/fs.c b/kernel/gcov/fs.c
index edf67c4..b31701a 100644
--- a/kernel/gcov/fs.c
+++ b/kernel/gcov/fs.c
@@ -437,7 +437,7 @@ static struct gcov_node *new_node(struct gcov_node *parent,
if (!node)
goto err_nomem;
if (info) {
- node->loaded_info = kcalloc(1, sizeof(struct gcov_info *),
+ node->loaded_info = kzalloc(sizeof(struct gcov_info *),
GFP_KERNEL);
if (!node->loaded_info)
goto err_nomem;
--
1.7.9.5

2015-06-22 14:13:12

by Peter Oberparleiter

Subject: Re: [Resend PATCH 1/1] kernel/gcov/fs.c: Use kzalloc for allocating one thing

On 22.06.2015 15:24, Maninder Singh wrote:
> Use kzalloc rather than kcalloc(1.. for allocation
> of one thing.
>
> Signed-off-by: Maninder Singh <[email protected]>
> Reviewed-by: Vaneet Narang <[email protected]>
> ---
> kernel/gcov/fs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/gcov/fs.c b/kernel/gcov/fs.c
> index edf67c4..b31701a 100644
> --- a/kernel/gcov/fs.c
> +++ b/kernel/gcov/fs.c
> @@ -437,7 +437,7 @@ static struct gcov_node *new_node(struct gcov_node *parent,
> if (!node)
> goto err_nomem;
> if (info) {
> - node->loaded_info = kcalloc(1, sizeof(struct gcov_info *),
> + node->loaded_info = kzalloc(sizeof(struct gcov_info *),

Using kcalloc makes it more obvious to readers that the entity being
allocated is in fact an array, even if it starts out with only one
element. This implicit bit of information would be lost when using
kzalloc. Therefore I'd like to keep the current version for better
readability.

> GFP_KERNEL);
> if (!node->loaded_info)
> goto err_nomem;
>

--
Peter Oberparleiter
Linux on z Systems Development - IBM Germany