2015-06-23 03:44:19

by Maninder Singh

Subject: [PATCH 1/1] scsi: remove redundant NULL check before kfree

There is no need of NULL check before kfree,
So removing the same.

Signed-off-by: Maninder Singh <[email protected]>
Reviewed-by: Rohit Thapliyal <[email protected]>
---
drivers/scsi/aic94xx/aic94xx_init.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/scsi/aic94xx/aic94xx_init.c b/drivers/scsi/aic94xx/aic94xx_init.c
index 4b135cc..a449fde 100644
--- a/drivers/scsi/aic94xx/aic94xx_init.c
+++ b/drivers/scsi/aic94xx/aic94xx_init.c
@@ -589,8 +589,7 @@ static void asd_destroy_ha_caches(struct asd_ha_struct *asd_ha)
if (asd_ha->hw_prof.scb_ext)
asd_free_coherent(asd_ha, asd_ha->hw_prof.scb_ext);

- if (asd_ha->hw_prof.ddb_bitmap)
- kfree(asd_ha->hw_prof.ddb_bitmap);
+ kfree(asd_ha->hw_prof.ddb_bitmap);
asd_ha->hw_prof.ddb_bitmap = NULL;

for (i = 0; i < ASD_MAX_PHYS; i++) {
--
1.7.9.5

2015-06-23 05:59:52

by Hannes Reinecke

Subject: Re: [PATCH 1/1] scsi: remove redundant NULL check before kfree

On 06/23/2015 05:42 AM, Maninder Singh wrote:
> There is no need of NULL check before kfree,
> So removing the same.
>
> Signed-off-by: Maninder Singh <[email protected]>
> Reviewed-by: Rohit Thapliyal <[email protected]>
If you insist ...

Reviewed-by: Hannes Reinecke <[email protected]>

Cheers,

Hannes
--
Dr. Hannes Reinecke zSeries & Storage
[email protected] +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 N?rnberg
GF: F. Imend?rffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG N?rnberg)