2015-07-02 05:04:25

by Tom Hebb

Subject: [PATCH 0/4] phy: berlin-usb: PLL divider fixes

The USB PLL dividers currently set by phy-berlin-usb are incorrect for
BG2 and BG2CD (i.e. all Berlin variants but BG2Q). This series fixes the
divider values for those two chips and additionally corrects the name of
the of_match table to no longer contain "sata" (which was presumably
mistakenly carried over from phy-berlin-sata).

I have verified that the new divider values work on BG2CD and Antoine
Tenart has verified that they work on BG2Q. The divider value for BG2
was taken from bootloader source but has not been tested.

Thomas Hebb (4):
phy: berlin-usb: fix divider for BG2CD
ARM: dts: berlin: change BG2Q's USB PHY compatible
phy: berlin-usb: fix divider for BG2
phy: berlin-usb: rename table copied from SATA PHY

arch/arm/boot/dts/berlin2q.dtsi | 6 +++---
drivers/phy/phy-berlin-usb.c | 12 ++++++------
2 files changed, 9 insertions(+), 9 deletions(-)

--
2.4.4

2015-07-03 09:22:53

by Antoine Tenart

Subject: Re: [PATCH 0/4] phy: berlin-usb: PLL divider fixes

Hi Thomas,

Thanks for this series!

On Thu, Jul 02, 2015 at 01:04:16AM -0400, Thomas Hebb wrote:
> The USB PLL dividers currently set by phy-berlin-usb are incorrect for
> BG2 and BG2CD (i.e. all Berlin variants but BG2Q). This series fixes the
> divider values for those two chips and additionally corrects the name of
> the of_match table to no longer contain "sata" (which was presumably
> mistakenly carried over from phy-berlin-sata).
>
> I have verified that the new divider values work on BG2CD and Antoine
> Tenart has verified that they work on BG2Q. The divider value for BG2
> was taken from bootloader source but has not been tested.

For the BG2Q,

Tested-by: Antoine Tenart <[email protected]>

>
> Thomas Hebb (4):
> phy: berlin-usb: fix divider for BG2CD
> ARM: dts: berlin: change BG2Q's USB PHY compatible
> phy: berlin-usb: fix divider for BG2
> phy: berlin-usb: rename table copied from SATA PHY
>
> arch/arm/boot/dts/berlin2q.dtsi | 6 +++---
> drivers/phy/phy-berlin-usb.c | 12 ++++++------
> 2 files changed, 9 insertions(+), 9 deletions(-)
>
> --
> 2.4.4
>

--
Antoine T?nart, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

2015-07-15 13:24:09

by Kishon Vijay Abraham I

Subject: Re: [PATCH 0/4] phy: berlin-usb: PLL divider fixes

Hi,

On Friday 03 July 2015 02:52 PM, Antoine Tenart wrote:
> Hi Thomas,
>
> Thanks for this series!
>
> On Thu, Jul 02, 2015 at 01:04:16AM -0400, Thomas Hebb wrote:
>> The USB PLL dividers currently set by phy-berlin-usb are incorrect for
>> BG2 and BG2CD (i.e. all Berlin variants but BG2Q). This series fixes the
>> divider values for those two chips and additionally corrects the name of
>> the of_match table to no longer contain "sata" (which was presumably
>> mistakenly carried over from phy-berlin-sata).
>>
>> I have verified that the new divider values work on BG2CD and Antoine
>> Tenart has verified that they work on BG2Q. The divider value for BG2
>> was taken from bootloader source but has not been tested.
>
> For the BG2Q,
>
> Tested-by: Antoine Tenart <[email protected]>

merged this series except
"ARM: dts: berlin: change BG2Q's USB PHY compatible"

Cheers
Kishon

>
>>
>> Thomas Hebb (4):
>> phy: berlin-usb: fix divider for BG2CD
>> ARM: dts: berlin: change BG2Q's USB PHY compatible
>> phy: berlin-usb: fix divider for BG2
>> phy: berlin-usb: rename table copied from SATA PHY
>>
>> arch/arm/boot/dts/berlin2q.dtsi | 6 +++---
>> drivers/phy/phy-berlin-usb.c | 12 ++++++------
>> 2 files changed, 9 insertions(+), 9 deletions(-)
>>
>> --
>> 2.4.4
>>
>