2015-07-08 05:55:13

by Rajat Jain

[permalink] [raw]
Subject: [PATCH] xen: Use module_pci_driver() in platform pci driver.

Eliminate the module_init function by using module_pci_driver()

Signed-off-by: Rajat Jain <[email protected]>
Signed-off-by: Rajat Jain <[email protected]>
---
drivers/xen/platform-pci.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/drivers/xen/platform-pci.c b/drivers/xen/platform-pci.c
index 3454973..3fb4d41 100644
--- a/drivers/xen/platform-pci.c
+++ b/drivers/xen/platform-pci.c
@@ -192,9 +192,4 @@ static struct pci_driver platform_driver = {
#endif
};

-static int __init platform_pci_module_init(void)
-{
- return pci_register_driver(&platform_driver);
-}
-
-module_init(platform_pci_module_init);
+module_pci_driver(platform_driver);
--
2.4.3.573.g4eafbef


2015-07-08 11:07:30

by David Vrabel

[permalink] [raw]
Subject: Re: [Xen-devel] [PATCH] xen: Use module_pci_driver() in platform pci driver.

On 08/07/15 06:54, Rajat Jain wrote:
> Eliminate the module_init function by using module_pci_driver()

This is not equivalent since this adds a useless module_exit() function.

David