2015-07-15 14:54:13

by Vinay Simha B N

[permalink] [raw]
Subject: [PATCH] pinctrl/qcom Kconfig CFG repeated

repeatation of the same configs
obj-$(CONFIG_PINCTRL_APQ8084) += pinctrl-apq8084.o

Signed-off-by: Vinay Simha BN <[email protected]>
---
drivers/pinctrl/qcom/Makefile | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/pinctrl/qcom/Makefile b/drivers/pinctrl/qcom/Makefile
index 3666c70..d26a878 100644
--- a/drivers/pinctrl/qcom/Makefile
+++ b/drivers/pinctrl/qcom/Makefile
@@ -1,7 +1,6 @@
# Qualcomm pin control drivers
obj-$(CONFIG_PINCTRL_MSM) += pinctrl-msm.o
obj-$(CONFIG_PINCTRL_APQ8064) += pinctrl-apq8064.o
-obj-$(CONFIG_PINCTRL_APQ8084) += pinctrl-apq8084.o
obj-$(CONFIG_PINCTRL_IPQ8064) += pinctrl-ipq8064.o
obj-$(CONFIG_PINCTRL_MSM8660) += pinctrl-msm8660.o
obj-$(CONFIG_PINCTRL_MSM8960) += pinctrl-msm8960.o
--
2.1.2


2015-07-15 15:04:48

by Stanimir Varbanov

[permalink] [raw]
Subject: Re: [PATCH] pinctrl/qcom Kconfig CFG repeated

On 07/15/2015 05:53 PM, Vinay Simha BN wrote:
> repeatation of the same configs
> obj-$(CONFIG_PINCTRL_APQ8084) += pinctrl-apq8084.o

hm you might be kidding, apq8064 and apq8084 are different SoCs.

>
> Signed-off-by: Vinay Simha BN <[email protected]>
> ---
> drivers/pinctrl/qcom/Makefile | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/pinctrl/qcom/Makefile b/drivers/pinctrl/qcom/Makefile
> index 3666c70..d26a878 100644
> --- a/drivers/pinctrl/qcom/Makefile
> +++ b/drivers/pinctrl/qcom/Makefile
> @@ -1,7 +1,6 @@
> # Qualcomm pin control drivers
> obj-$(CONFIG_PINCTRL_MSM) += pinctrl-msm.o
> obj-$(CONFIG_PINCTRL_APQ8064) += pinctrl-apq8064.o
> -obj-$(CONFIG_PINCTRL_APQ8084) += pinctrl-apq8084.o
> obj-$(CONFIG_PINCTRL_IPQ8064) += pinctrl-ipq8064.o
> obj-$(CONFIG_PINCTRL_MSM8660) += pinctrl-msm8660.o
> obj-$(CONFIG_PINCTRL_MSM8960) += pinctrl-msm8960.o
>


--
regards,
Stan

2015-07-15 15:35:30

by Vinay Simha B N

[permalink] [raw]
Subject: Re: [PATCH] pinctrl/qcom Kconfig CFG repeated

sorry. My mistake. i saw both as 8064.

On Wed, Jul 15, 2015 at 8:34 PM, Stanimir Varbanov <[email protected]> wrote:
> On 07/15/2015 05:53 PM, Vinay Simha BN wrote:
>> repeatation of the same configs
>> obj-$(CONFIG_PINCTRL_APQ8084) += pinctrl-apq8084.o
>
> hm you might be kidding, apq8064 and apq8084 are different SoCs.
>
>>
>> Signed-off-by: Vinay Simha BN <[email protected]>
>> ---
>> drivers/pinctrl/qcom/Makefile | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/pinctrl/qcom/Makefile b/drivers/pinctrl/qcom/Makefile
>> index 3666c70..d26a878 100644
>> --- a/drivers/pinctrl/qcom/Makefile
>> +++ b/drivers/pinctrl/qcom/Makefile
>> @@ -1,7 +1,6 @@
>> # Qualcomm pin control drivers
>> obj-$(CONFIG_PINCTRL_MSM) += pinctrl-msm.o
>> obj-$(CONFIG_PINCTRL_APQ8064) += pinctrl-apq8064.o
>> -obj-$(CONFIG_PINCTRL_APQ8084) += pinctrl-apq8084.o
>> obj-$(CONFIG_PINCTRL_IPQ8064) += pinctrl-ipq8064.o
>> obj-$(CONFIG_PINCTRL_MSM8660) += pinctrl-msm8660.o
>> obj-$(CONFIG_PINCTRL_MSM8960) += pinctrl-msm8960.o
>>
>
>
> --
> regards,
> Stan



--
Regards,

Vinay Simha.B.N.

2015-07-17 12:37:51

by Linus Walleij

[permalink] [raw]
Subject: Re: [PATCH] pinctrl/qcom Kconfig CFG repeated

On Wed, Jul 15, 2015 at 5:35 PM, Vinay Simha <[email protected]> wrote:

> sorry. My mistake. i saw both as 8064.

Perceptual problem, happens to me too, all the time.

Qualcomm: give your chips more distinguishable names,
the neural hamming distance is too short.

Yours,
Linus Walleij