2015-06-09 21:47:21

by Peter Griffin

Subject: [PATCH] ARM: STi: Remove platform call to trace_hardirqs_off()

Calling trace_hardirqs_off() from the platform specific
secondary startup code as not been necessary since Dec 2010
when Russell King consolidated the call into the common SMP
code.

2c0136d ARM: SMP: consolidate trace_hardirqs_off() into common SMP code

Signed-off-by: Peter Griffin <[email protected]>
---
arch/arm/mach-sti/platsmp.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/arch/arm/mach-sti/platsmp.c b/arch/arm/mach-sti/platsmp.c
index d4b624f..a39f812 100644
--- a/arch/arm/mach-sti/platsmp.c
+++ b/arch/arm/mach-sti/platsmp.c
@@ -38,8 +38,6 @@ static DEFINE_SPINLOCK(boot_lock);

static void sti_secondary_init(unsigned int cpu)
{
- trace_hardirqs_off();
-
/*
* let the primary processor know we're out of the
* pen, then head off into the C entry point
--
1.9.1

2015-06-10 07:40:24

by Lee Jones

Subject: Re: [PATCH] ARM: STi: Remove platform call to trace_hardirqs_off()

On Tue, 09 Jun 2015, Peter Griffin wrote:

> Calling trace_hardirqs_off() from the platform specific
> secondary startup code as not been necessary since Dec 2010
> when Russell King consolidated the call into the common SMP
> code.
>
> 2c0136d ARM: SMP: consolidate trace_hardirqs_off() into common SMP code
>
> Signed-off-by: Peter Griffin <[email protected]>
> ---
> arch/arm/mach-sti/platsmp.c | 2 --
> 1 file changed, 2 deletions(-)

Acked-by: Lee Jones <[email protected]>

> diff --git a/arch/arm/mach-sti/platsmp.c b/arch/arm/mach-sti/platsmp.c
> index d4b624f..a39f812 100644
> --- a/arch/arm/mach-sti/platsmp.c
> +++ b/arch/arm/mach-sti/platsmp.c
> @@ -38,8 +38,6 @@ static DEFINE_SPINLOCK(boot_lock);
>
> static void sti_secondary_init(unsigned int cpu)
> {
> - trace_hardirqs_off();
> -
> /*
> * let the primary processor know we're out of the
> * pen, then head off into the C entry point

--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

2015-06-10 08:12:13

by Maxime Coquelin

Subject: Re: [PATCH] ARM: STi: Remove platform call to trace_hardirqs_off()

Hi Peter

On 06/09/2015 11:47 PM, Peter Griffin wrote:
> Calling trace_hardirqs_off() from the platform specific
> secondary startup code as not been necessary since Dec 2010
> when Russell King consolidated the call into the common SMP
> code.
>
> 2c0136d ARM: SMP: consolidate trace_hardirqs_off() into common SMP code
>
> Signed-off-by: Peter Griffin <[email protected]>
> ---
> arch/arm/mach-sti/platsmp.c | 2 --
> 1 file changed, 2 deletions(-)
>
>

Acked-by: Maxime Coquelin <[email protected]>

Thanks!
Maxime

2015-07-22 09:18:25

by Maxime Coquelin

Subject: Re: [PATCH] ARM: STi: Remove platform call to trace_hardirqs_off()

HI Peter,

On 06/09/2015 11:47 PM, Peter Griffin wrote:
> Calling trace_hardirqs_off() from the platform specific
> secondary startup code as not been necessary since Dec 2010
> when Russell King consolidated the call into the common SMP
> code.
>
> 2c0136d ARM: SMP: consolidate trace_hardirqs_off() into common SMP code
>
> Signed-off-by: Peter Griffin <[email protected]>
> ---
> arch/arm/mach-sti/platsmp.c | 2 --
> 1 file changed, 2 deletions(-)
>

Applied to sti-soc-for-v4.3.

Thanks!
Maxime