2015-08-06 07:16:57

by Johannes Thumshirn

Subject: [PATCHv2 0/2] tty: serial: men_z135_uart.c: Updates for men_z135_uart

Version two of the updates for the men_z135_uart, incorporating Peter's review
comments.

1/2: Use spin_lock_irq() in settermios() and spin_lock() in ISR to avoid
deadlocks.
2/2: Removes the double initialization of the port.lock spinlock.

Johannes Thumshirn (2):
tty: serial: men_z135_uart.c: Fix race between IRQ and set_termios()
tty: serial: men_z135_uart.c: Don't initialize port->lock

drivers/tty/serial/men_z135_uart.c | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)

--
2.4.6

2015-08-06 07:17:04

by Johannes Thumshirn

Subject: [PATCH 2/2] tty: serial: men_z135_uart.c: Don't initialize port->lock

port->lock get's initialized in uart_add_one_port(), no need to do it
in men_z135_probe().

Signed-off-by: Johannes Thumshirn <[email protected]>
Cc: Peter Hurley <[email protected]>
---
drivers/tty/serial/men_z135_uart.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/tty/serial/men_z135_uart.c b/drivers/tty/serial/men_z135_uart.c
index 5a41b8fb..b90e7b3 100644
--- a/drivers/tty/serial/men_z135_uart.c
+++ b/drivers/tty/serial/men_z135_uart.c
@@ -839,7 +839,6 @@ static int men_z135_probe(struct mcb_device *mdev,
uart->port.membase = NULL;
uart->mdev = mdev;

- spin_lock_init(&uart->port.lock);
spin_lock_init(&uart->lock);

err = uart_add_one_port(&men_z135_driver, &uart->port);
--
2.4.6

2015-08-06 11:30:01

by Peter Hurley

Subject: Re: [PATCH 2/2] tty: serial: men_z135_uart.c: Don't initialize port->lock

On 08/06/2015 03:16 AM, Johannes Thumshirn wrote:
> port->lock get's initialized in uart_add_one_port(), no need to do it
> in men_z135_probe().

Reviewed-by: Peter Hurley <[email protected]>