2024-04-09 22:26:24

by Mark Brown

Subject: [PATCH] selftests/clone3: Fix compiler warning

Shuah reported a compiler warning with an Ubuntu GCC 13 build, I've been
unable to reproduce it but hopefully this fixes the issue:

clone3_set_tid.c:136:43: warning: format ‘%d’ expects argument of type ‘int’, but argument 3 has type ‘size_t’ {aka ‘long unsigned int’} [-Wformat=]

Reported-by: Shuah Khan <[email protected]>
Signed-off-by: Mark Brown <[email protected]>
---
tools/testing/selftests/clone3/clone3_set_tid.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/clone3/clone3_set_tid.c b/tools/testing/selftests/clone3/clone3_set_tid.c
index 9ae38733cb6e..fbf813a5a06f 100644
--- a/tools/testing/selftests/clone3/clone3_set_tid.c
+++ b/tools/testing/selftests/clone3/clone3_set_tid.c
@@ -133,7 +133,7 @@ static void test_clone3_set_tid(const char *desc,
"[%d] clone3() with CLONE_SET_TID %d says: %d - expected %d\n",
getpid(), set_tid[0], ret, expected);

- ksft_test_result(ret == expected, "%s with %d TIDs and flags 0x%x\n",
+ ksft_test_result(ret == expected, "%s with %zu TIDs and flags 0x%x\n",
desc, set_tid_size, flags);
}


---
base-commit: a053fd3ca5d1b927a8655f239c84b0d790218fda
change-id: 20240409-clone3-warning-fix-89a363c6899e

Best regards,
--
Mark Brown <[email protected]>

2024-04-11 21:04:20

by Shuah Khan

Subject: Re: [PATCH] selftests/clone3: Fix compiler warning

On 4/9/24 16:24, Mark Brown wrote:
> Shuah reported a compiler warning with an Ubuntu GCC 13 build, I've been
> unable to reproduce it but hopefully this fixes the issue:
>
> clone3_set_tid.c:136:43: warning: format ‘%d’ expects argument of type ‘int’, but argument 3 has type ‘size_t’ {aka ‘long unsigned int’} [-Wformat=]
>
> Reported-by: Shuah Khan <[email protected]>
> Signed-off-by: Mark Brown <[email protected]>
> ---
> tools/testing/selftests/clone3/clone3_set_tid.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/clone3/clone3_set_tid.c b/tools/testing/selftests/clone3/clone3_set_tid.c
> index 9ae38733cb6e..fbf813a5a06f 100644
> --- a/tools/testing/selftests/clone3/clone3_set_tid.c
> +++ b/tools/testing/selftests/clone3/clone3_set_tid.c
> @@ -133,7 +133,7 @@ static void test_clone3_set_tid(const char *desc,
> "[%d] clone3() with CLONE_SET_TID %d says: %d - expected %d\n",
> getpid(), set_tid[0], ret, expected);
>
> - ksft_test_result(ret == expected, "%s with %d TIDs and flags 0x%x\n",
> + ksft_test_result(ret == expected, "%s with %zu TIDs and flags 0x%x\n",
> desc, set_tid_size, flags);
> }
>
>
> ---
> base-commit: a053fd3ca5d1b927a8655f239c84b0d790218fda
> change-id: 20240409-clone3-warning-fix-89a363c6899e
>
> Best regards,

Applied to linux-kselftest next for Linux 6.10-rc1.

thanks,
-- Shuah