2023-09-19 17:39:21

by Luiz Capitulino

[permalink] [raw]
Subject: Re: [PATH v2] cgroup: add cgroup_favordynmods= command-line option



On 2023-09-19 07:00, Michal Koutný wrote:
> On Mon, Sep 18, 2023 at 07:47:13AM -1000, Tejun Heo <[email protected]> wrote:
>> Michal raised some valid concerns. I don't really mind that it's not great
>> on the edges tho. Michal, what do you think?
>
> I'd have a few suggestions:
> - reset to have_dynmods value instead of false in cgroup_destroy_root()
> (to the benefing of the users of this option, not the common default
> users) or not touch the value in cgroup_destroy_root() at all
> - s/CONFIG_FAVOR_DYNMODS/CONFIG_CGROUP_FAVOR_DYNMODS/ in commit message

Thank you for the detailed suggestions, Michal. I'll on this for v3.

- Luiz