2015-11-02 01:00:04

by Matthew Fernandez

[permalink] [raw]
Subject: [PATCH] bpf: fix trivial comment typo

bpf: fix trivial comment typo

Signed-off-by: Matthew Fernandez <[email protected]>

diff --git a/kernel/bpf/core.c b/kernel/bpf/core.c
index 67c380c..996db5c 100644
--- a/kernel/bpf/core.c
+++ b/kernel/bpf/core.c
@@ -456,7 +456,7 @@ select_insn:

/* ARG1 at this point is guaranteed to point to CTX from
* the verifier side due to the fact that the tail call is
- * handeled like a helper, that is, bpf_tail_call_proto,
+ * handled like a helper, that is, bpf_tail_call_proto,
* where arg1_type is ARG_PTR_TO_CTX.
*/
insn = prog->insnsi;


2015-11-02 21:31:42

by David Miller

[permalink] [raw]
Subject: Re: [PATCH] bpf: fix trivial comment typo

From: Matthew Fernandez <[email protected]>
Date: Mon, 2 Nov 2015 11:59:03 +1100

> bpf: fix trivial comment typo
>
> Signed-off-by: Matthew Fernandez <[email protected]>

This doesn't apply to any tree.

2015-11-02 21:48:25

by Matthew Fernandez

[permalink] [raw]
Subject: Re: [PATCH] bpf: fix trivial comment typo

On 03/11/15 08:31, David Miller wrote:
> From: Matthew Fernandez <[email protected]>
> Date: Mon, 2 Nov 2015 11:59:03 +1100
>
>> bpf: fix trivial comment typo
>>
>> Signed-off-by: Matthew Fernandez <[email protected]>
>
> This doesn't apply to any tree.

I'm sorry, I think I must be missing something. This seems to apply cleanly to the current tip of mainline
(e86328c489d7) to me. Was this not in the expected format? It wasn't my intention to waste your time, so I apologise for
any newbie errors.

2015-11-03 09:48:52

by Daniel Borkmann

[permalink] [raw]
Subject: Re: [PATCH] bpf: fix trivial comment typo

On 11/02/2015 10:48 PM, Matthew Fernandez wrote:
> On 03/11/15 08:31, David Miller wrote:
>> From: Matthew Fernandez <[email protected]>
>> Date: Mon, 2 Nov 2015 11:59:03 +1100
>>
>>> bpf: fix trivial comment typo
>>>
>>> Signed-off-by: Matthew Fernandez <[email protected]>
>>
>> This doesn't apply to any tree.
>
> I'm sorry, I think I must be missing something. This seems to apply cleanly to the current tip of mainline (e86328c489d7) to me. Was this not in the expected format? It wasn't my intention to waste your time, so I apologise for any newbie errors.

You might want to check Documentation/networking/netdev-FAQ.txt ;),
and rebase your spelling fix f.e. to the latest net-next tree.

2015-11-05 00:06:10

by Matthew Fernandez

[permalink] [raw]
Subject: Re: [PATCH] bpf: fix trivial comment typo

On 03/11/15 20:48, Daniel Borkmann wrote:
> On 11/02/2015 10:48 PM, Matthew Fernandez wrote:
>> On 03/11/15 08:31, David Miller wrote:
>>> From: Matthew Fernandez <[email protected]>
>>> Date: Mon, 2 Nov 2015 11:59:03 +1100
>>>
>>>> bpf: fix trivial comment typo
>>>>
>>>> Signed-off-by: Matthew Fernandez <[email protected]>
>>>
>>> This doesn't apply to any tree.
>>
>> I'm sorry, I think I must be missing something. This seems to apply cleanly to the current tip of
>> mainline (e86328c489d7) to me. Was this not in the expected format? It wasn't my intention to
>> waste your time, so I apologise for any newbie errors.
>
> You might want to check Documentation/networking/netdev-FAQ.txt ;),
> and rebase your spelling fix f.e. to the latest net-next tree.

Ah right, sorry about that. Thanks for the info, Daniel. From netdev-FAQ it sounds like this patch
would be more appropriate for the net tree, but as the target file is identical in both right now
I'll leave it to someone else's discretion to decide which is more suitable. Will rebase and resubmit.