2015-11-12 10:18:36

by Andreas Ziegler

[permalink] [raw]
Subject: Re: MIPS: BMIPS: Enable GZIP ramdisk and timed printks

Hi Florian,

your patch "MIPS: BMIPS: Enable GZIP ramdisk and timed printks"
showed up as commit fb9e5642aa9e in linux-next today (that is,
next-20151112). I noticed it because we (a research group from
Erlangen[0]) are running daily checks on linux-next.

Your commit adds two entries to arch/mips/configs/bmips_stb_defconfig,
but one of them has a typo (line 37):

CONFIG_PRINK_TIME=y

which should instead say (notice the missing 'T'):

CONFIG_PRINTK_TIME=y

Not sure how this got two Reviewed-by's, as this simple mistake could
have been easily spotted by running scripts/checkkconfigsymbols.py on
the patch.

Regards,

Andreas

[0] https://cados.cs.fau.de
Original patchwork: https://patchwork.linux-mips.org/patch/11307/


2015-11-12 10:36:58

by Ralf Baechle

[permalink] [raw]
Subject: Re: MIPS: BMIPS: Enable GZIP ramdisk and timed printks

On Thu, Nov 12, 2015 at 11:18:30AM +0100, Andreas Ziegler wrote:

> Hi Florian,
>
> your patch "MIPS: BMIPS: Enable GZIP ramdisk and timed printks"
> showed up as commit fb9e5642aa9e in linux-next today (that is,
> next-20151112). I noticed it because we (a research group from
> Erlangen[0]) are running daily checks on linux-next.
>
> Your commit adds two entries to arch/mips/configs/bmips_stb_defconfig,
> but one of them has a typo (line 37):
>
> CONFIG_PRINK_TIME=y
>
> which should instead say (notice the missing 'T'):
>
> CONFIG_PRINTK_TIME=y
>
> Not sure how this got two Reviewed-by's, as this simple mistake could
> have been easily spotted by running scripts/checkkconfigsymbols.py on
> the patch.

Sigh, fixed.

Ralf